FIX: typo in attribute lookup by tacaswell · Pull Request #15422 · matplotlib/matplotlib · GitHub
Skip to content

FIX: typo in attribute lookup - #15422

Merged
timhoffm merged 1 commit into
matplotlib:masterfrom
tacaswell:fix_qt_typo
Oct 16, 2019
Merged

timhoffm merged 1 commit into
matplotlib:masterfrom
tacaswell:fix_qt_typo

Conversation

@tacaswell

Copy link
Copy Markdown
Member

The attribute is _is_drawing not ._is_drawing

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

The attribute is `_is_drawing` not `._is_drawing`
@tacaswell tacaswell added this to the v2.2.5 milestone Oct 15, 2019
@tacaswell tacaswell added the Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. label Oct 15, 2019

@timhoffm timhoffm left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build errors are in the setup of the CI and unrelated to this PR.

@timhoffm
timhoffm merged commit 8ea326c into matplotlib:master Oct 16, 2019
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Oct 16, 2019
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Oct 16, 2019
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Oct 16, 2019
@tacaswell
tacaswell deleted the fix_qt_typo branch October 16, 2019 12:45
tacaswell added a commit that referenced this pull request Oct 16, 2019
…422-on-v3.1.x

Backport PR #15422 on branch v3.1.x (FIX: typo in attribute lookup)
jklymak added a commit that referenced this pull request Oct 16, 2019
…422-on-v2.2.x

Backport PR #15422 on branch v2.2.x (FIX: typo in attribute lookup)
timhoffm added a commit to timhoffm/matplotlib that referenced this pull request Oct 17, 2019
tacaswell added a commit that referenced this pull request Oct 19, 2019
…422-on-v3.2.x

Backport PR #15422 on branch v3.2.x (FIX: typo in attribute lookup)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants