{{ message }}
Propagate signature-modifying decorators to pyplot wrappers. - #15254
Merged
Merged
Conversation
2 tasks
timhoffm
reviewed
Sep 12, 2019
anntzer
force-pushed
the
propagate-decorators
branch
from
September 13, 2019 08:53
b0f1695 to
144b913
Compare
anntzer
force-pushed
the
propagate-decorators
branch
from
October 15, 2019 19:57
144b913 to
61a21ba
Compare
anntzer
force-pushed
the
propagate-decorators
branch
from
December 16, 2019 12:18
61a21ba to
fbffe2f
Compare
6 tasks
anntzer
force-pushed
the
propagate-decorators
branch
3 times, most recently
from
February 26, 2020 14:11
e8597f7 to
ce1eed0
Compare
timhoffm
approved these changes
Feb 28, 2020
Member
Member
|
There's no final decision between this and #14130 yet. In the end, I don't have a very strong opinion anymore on which one to choose. The important thing is that we get one of them in, so that we can properly rename parameters and propagate that to pyplot. Since this is internal functionality, we could even switch out the solution if we realize the other one was better. In practice, we need a second positive review so that this can get merged. The confict is indeed trivial to solve by regenerating the code. |
anntzer
force-pushed
the
propagate-decorators
branch
from
March 21, 2020 23:53
ce1eed0 to
73746d6
Compare
Contributor
Author
|
rebased |
QuLogic
approved these changes
Mar 22, 2020
Member
|
I want to merge, but I'm wondering if there's an example that would trigger this yet? |
Member
QuLogic
added
the
API: argument checking
ksunden
added a commit
to ksunden/matplotlib
that referenced
this pull request
Mar 26, 2020
Remove specification for where the old parameter remains supported This was fixed by merging matplotlib#15254
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
alternative to #14130, see discussion there; attn @timhoffm
PR Checklist