{{ message }}
By default, don't change the figure face/edgecolor on savefig(). - #15111
Merged
Conversation
anntzer
force-pushed
the
savefigcolorauto
branch
from
August 23, 2019 13:45
ec90642 to
cec9ed4
Compare
Member
Contributor
Author
|
For colors, there's already places that accept "auto" and places that accept "inherit" (specifically, legends). I'd rather not add a third spelling for the same (general) idea. (In fact I plan to deprecate "inherit" in favor of "auto", but that's a separate issue.) |
anntzer
force-pushed
the
savefigcolorauto
branch
from
August 23, 2019 17:23
cec9ed4 to
7f9dea1
Compare
Member
|
|
anntzer
force-pushed
the
savefigcolorauto
branch
from
August 24, 2019 10:32
7f9dea1 to
4e36c54
Compare
Contributor
Author
|
So what do you think the "auto" cases of lines.markerfacecolor, lines.markeredgecolor, boxplot.flierprops.markerfacecolor, and axes.titlecolor should be named? |
anntzer
force-pushed
the
savefigcolorauto
branch
from
September 27, 2019 09:39
4e36c54 to
bfc7093
Compare
anntzer
force-pushed
the
savefigcolorauto
branch
from
October 8, 2019 20:06
bfc7093 to
12a81c7
Compare
anntzer
force-pushed
the
savefigcolorauto
branch
from
January 21, 2020 00:19
12a81c7 to
1552f80
Compare
This seems to repeatedly confuse users.
efiring
approved these changes
May 4, 2020
efiring
left a comment
efiring
left a comment
Member
There was a problem hiding this comment.
Seems like a good idea: a move towards the goal of minimizing surprise.
Member
This was referenced Apr 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This seems to repeatedly confuse users.
Closes #7619; fixes https://gitter.im/matplotlib/matplotlib?at=5d5faff768406739f96b2673; alternate for #10023.
PR Summary
PR Checklist