Clarify unnecessary special handling for colons in paths. by anntzer · Pull Request #15050 · matplotlib/matplotlib · GitHub
Skip to content

Clarify unnecessary special handling for colons in paths. - #15050

Merged
timhoffm merged 1 commit into
matplotlib:masterfrom
anntzer:colons
Aug 13, 2019
Merged

Clarify unnecessary special handling for colons in paths.#15050
timhoffm merged 1 commit into
matplotlib:masterfrom
anntzer:colons

Conversation

@anntzer

@anntzer anntzer commented Aug 13, 2019

Copy link
Copy Markdown
Contributor

PR Summary

following ongoing discussion at #15048 (comment)

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@ImportanceOfBeingErnest

ImportanceOfBeingErnest commented Aug 13, 2019 •
edited
Loading

Copy link
Copy Markdown
Member

@anntzer anntzer changed the title Remove unnecessary special handling for colons in paths. Clarify unnecessary special handling for colons in paths. Aug 13, 2019
@anntzer

anntzer commented Aug 13, 2019

Copy link
Copy Markdown
Contributor Author

@dstansby dstansby added this to the v3.2.0 milestone Aug 13, 2019
dstansby
dstansby approved these changes Aug 13, 2019
View reviewed changes

@dstansby dstansby left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 when CI passes

@timhoffm
timhoffm merged commit 453ff14 into matplotlib:master Aug 13, 2019
@anntzer
anntzer deleted the colons branch August 13, 2019 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@timhoffm timhoffm timhoffm approved these changes
@dstansby dstansby dstansby approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v3.2.0

Development

Successfully merging this pull request may close these issues.

4 participants

@anntzer @ImportanceOfBeingErnest @timhoffm @dstansby