Deduplicate wx configure_subplots tool. by anntzer · Pull Request #14732 · matplotlib/matplotlib · GitHub
Skip to content

Deduplicate wx configure_subplots tool. - #14732

Merged
QuLogic merged 1 commit into
matplotlib:masterfrom
anntzer:wxconfsubplottoolmanager
Jul 17, 2019
Merged

QuLogic merged 1 commit into
matplotlib:masterfrom
anntzer:wxconfsubplottoolmanager

Conversation

@anntzer

@anntzer anntzer commented Jul 9, 2019

Copy link
Copy Markdown
Contributor

... by using the old toolbar implementation instead.

Basically the same as #14569, but for wx.

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

... by using the old toolbar implementation instead.
@anntzer anntzer added the GUI: wx label Jul 9, 2019

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very technically this is also a backwards incompatible change because one cannot pass evt as kwarg anymore, but I'm not going to lose sleep over that (the signature is now consistent with pan and zoom).

@QuLogic
QuLogic merged commit d07e36d into matplotlib:master Jul 17, 2019
@QuLogic QuLogic added this to the v3.2.0 milestone Jul 17, 2019
@anntzer
anntzer deleted the wxconfsubplottoolmanager branch July 18, 2019 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants