{{ message }}
Bump to flake8 3.7. - #13337
Merged
Merged
Bump to flake8 3.7.#13337
Conversation
The associated bump to pycodestyle 2.5 caught a few more style nits.
Contributor
Member
|
It looks like appveyor did not fire, maybe this is the coverage we get only from appveyor? |
tacaswell
requested changes
Feb 1, 2019
timhoffm
approved these changes
Feb 1, 2019
Member
|
Might be that we need to take care of flake8 also in the other branches (e.g. it's failing in this backport #13340). |
tacaswell
approved these changes
Feb 1, 2019
Member
|
@meeseeksbot backport to v3.0.x |
Member
|
@meeseeksdev backport to v3.0.x |
|
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulation you did some good work ! Hopefully your backport PR will be tested by the continuous integration and merged soon! If these instruction are inaccurate, feel free to suggest an improvement. |
Member
|
OK, I'll put it in #13418. |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

flake8 3.7 seems to be working fine now.
The associated bump to pycodestyle 2.5 caught a few more style nits.
PR Summary
PR Checklist