Deprecate NavigationToolbar2GTK3.ctx. by anntzer · Pull Request #13144 · matplotlib/matplotlib · GitHub
Skip to content

Deprecate NavigationToolbar2GTK3.ctx. - #13144

Merged
timhoffm merged 1 commit into
matplotlib:masterfrom
anntzer:deprecate-navtoolbar-ctx
Apr 22, 2020
Merged

timhoffm merged 1 commit into
matplotlib:masterfrom
anntzer:deprecate-navtoolbar-ctx

Conversation

@anntzer

@anntzer anntzer commented Jan 10, 2019

Copy link
Copy Markdown
Contributor

No alternative documented: messing with the window cairo context is
quite low level; if you're doing that, creating the context should not
be that hard.

Intentionally not changing it on RubberbandGTK3 as that's handled by #12760.

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer
anntzer force-pushed the deprecate-navtoolbar-ctx branch from 66e6842 to d007262 Compare July 5, 2019 19:33

@QuLogic QuLogic left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also move deprecation to new location.

Comment thread lib/matplotlib/backends/backend_gtk3.py Outdated
@QuLogic QuLogic added this to the v3.3.0 milestone Apr 22, 2020
No alternative documented: messing with the window cairo context is
quite low level; if you're doing that, creating the context should not
be that hard.
@anntzer

anntzer commented Apr 22, 2020

Copy link
Copy Markdown
Contributor Author

@anntzer
anntzer force-pushed the deprecate-navtoolbar-ctx branch from d007262 to c5946e1 Compare April 22, 2020 08:03
@timhoffm
timhoffm merged commit 4d927de into matplotlib:master Apr 22, 2020
@anntzer
anntzer deleted the deprecate-navtoolbar-ctx branch April 22, 2020 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants