{{ message }}
Debundle pyparsing#1290
Closed
Xarthisius wants to merge 9 commits into
Closed
Conversation
Member
Contributor
Author
|
Fair enough, I'll work on less intrusive solution. Perhaps, checking for system pyparsing and fallback to bundled one if former is not found? |
Member
|
Yes -- that's what we do with dateutil and pytz at the moment. |
Contributor
Author
|
Oh geez, I've made a mess... I wasn't aware that all my random commits will be subject to validation via Travis. Sorry for wasting your cycles. |
Member
|
Don't worry about wasting our cycles -- you're saving a lot of our human cycles by working on this! You may also be interested in MEP11 -- which began in part as a result of this PR -- and the associated discussion on the mailing list. |
Member
|
@mdboom & @Xarthisius - where does this sit with the new setup machinery? Is this now obsolete? |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I'd like to revisit the issue of bundling pyparsing [1],[2]. Recently I've encounter python project that did import matplotlib.pyparsing so it's getting slightly out of hand. My question: do original point of "pyparsing API being too fluid" still stands, were your patches merged? Upstream repository seems to be quiet at the moment. Also I've been using maplotlib with pyparsing-1.5.6 without any problems
Cheers,
Kacper
[1] http://www.mail-archive.com/matplotlib-devel@lists.sourceforge.net/msg05108.html
[2] https://bugs.gentoo.org/show_bug.cgi?id=260025