Add ishistogammed option to the hist plotting method - #12306
shane-breeze wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
I'd rather you just use plt.bar instead... no?
(Yes, you will have to perform some additional calculations yourself if you want e.g. to get a cumulative histogram, but if you already went through the bother of doing the histogramming then an additional cumsum() is not too hard.)
Feel free to dismiss this review if there's consensus to do so.
|
My knee-jerk reaction is that I'm also against overloading |
|
Looks like because |

PR Summary
The option
ishistogrammedto thehistplotting method, e.g.This is used if
xis already histogrammed through thenp.histogramfunction (or similar).Use case:
xis too large to pass toplt.histin one go then the user can histogram in chunks themselves and then pass the summed histograms to do the plotting.PR Checklist