{{ message }}
Don't associate Wx timers with the parent frame. - #11590
Merged
DietmarSchwertberger merged 1 commit intoJul 9, 2018
Merged
Conversation
anntzer
added
Release critical
6 tasks
Member
Contributor
Author
|
done |
anntzer
force-pushed
the
parentlesswxtimers
branch
from
July 8, 2018 15:58
03ed370 to
9d4cc11
Compare
Contributor
Author
|
Doesn't segfault travis anymore, but still fails (as you noted, on a timeout). Let's keep this wx test disabled? |
Member
|
Yes, leave |
Contributor
Author
|
I'm puzzled why wx fails when wxagg works (they should share the same code re: interactivity), but sure... |
anntzer
force-pushed
the
parentlesswxtimers
branch
from
July 8, 2018 19:00
9d4cc11 to
27e9c2b
Compare
Member
|
Given that it is timing out probably something subtle in the draw / render / put the window on the (fake) screen process? |
Contributor
Author
|
Well, that still fails. Let's just get rid of the wx test. |
This is consistent with the behavior on Qt and GTK, and avoids a segfault due to lack of disconnection of the timer after the parent widget is destroyed (otherwise, we'd need to keep track of timers associated with each widget and tear them down when the widget is destroyed).
anntzer
force-pushed
the
parentlesswxtimers
branch
from
July 8, 2018 20:05
27e9c2b to
4270fd0
Compare
Member
|
@DietmarSchwertberger Can you review this? |
tacaswell
approved these changes
Jul 9, 2018
DietmarSchwertberger
approved these changes
Jul 9, 2018
Contributor
|
Looks good to me. Pending events are the most common source of segfaults... |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is consistent with the behavior on Qt and GTK, and avoids a
segfault due to lack of disconnection of the timer after the parent
widget is destroyed (otherwise, we'd need to keep track of timers
associated with each widget and tear them down when the widget is
destroyed).
Closes #11582.
Marking as release-critical per "fixes a segfault", though not a regression so not insisting on it.
PR Summary
PR Checklist