iframe-proxy

ImportanceOfBeingErnest · 2018-06-13T11:12:22Z

PR Summary

The path editor example errors when being run with an interactive backend, due to a recursion in drawing the elements.

This PR fixes this issue by not blitting inside the draw_event (because that happens before the screen update anyways).

anntzer

I can't manage to trigger any error with the example as it is right now, and removing the blit line makes the example not work anymore on tkagg for me.

Anyone can dismiss the review if this problem is sorted out.

ImportanceOfBeingErnest · 2018-06-13T20:19:53Z

Ok, seems this needs some more detailed bug report.

With Qt5Agg backend, py 3.6 on windows 8.1, running the example as script produces

This error (hidden for convenience)

QWidget::repaint: Recursive repaint detected
QWidget::repaint: Recursive repaint detected
QWidget::repaint: Recursive repaint detected
QWidget::repaint: Recursive repaint detected
QWidget::repaint: Recursive repaint detected
QWidget::repaint: Recursive repaint detected
QWidget::repaint: Recursive repaint detected
QWidget::repaint: Recursive repaint detected
QWidget::repaint: Recursive repaint detected
QWidget::repaint: Recursive repaint detected
QWidget::repaint: Recursive repaint detected
QWidget::repaint: Recursive repaint detected
QWidget::repaint: Recursive repaint detected
QWidget::repaint: Recursive repaint detected
QWidget::repaint: Recursive repaint detected
QWidget::repaint: Recursive repaint detected
QWidget::repaint: Recursive repaint detected
QWidget::repaint: Recursive repaint detected
QWidget::repaint: Recursive repaint detected
QWidget::repaint: Recursive repaint detected
QWidget::repaint: Recursive repaint detected
QWidget::repaint: Recursive repaint detected
QWidget::repaint: Recursive repaint detected
QWidget::repaint: Recursive repaint detected
QWidget::repaint: Recursive repaint detected
QWidget::repaint: Recursive repaint detected
QWidget::repaint: Recursive repaint detected
QWidget::repaint: Recursive repaint detected
QWidget::repaint: Recursive repaint detected
QWidget::repaint: Recursive repaint detected
QWidget::repaint: Recursive repaint detected
QWidget::repaint: Recursive repaint detected
QWidget::repaint: Recursive repaint detected
QWidget::repaint: Recursive repaint detected
QWidget::repaint: Recursive repaint detected
QWidget::repaint: Recursive repaint detected
QWidget::repaint: Recursive repaint detected
QWidget::repaint: Recursive repaint detected
QWidget::repaint: Recursive repaint detected
QWidget::repaint: Recursive repaint detected
QWidget::repaint: Recursive repaint detected
QWidget::repaint: Recursive repaint detected
QWidget::repaint: Recursive repaint detected
QWidget::repaint: Recursive repaint detected
QWidget::repaint: Recursive repaint detected
QWidget::repaint: Recursive repaint detected
QWidget::repaint: Recursive repaint detected
QWidget::repaint: Recursive repaint detected
QWidget::repaint: Recursive repaint detected
QWidget::repaint: Recursive repaint detected
QWidget::repaint: Recursive repaint detected
QWidget::repaint: Recursive repaint detected
Traceback (most recent call last):
  File "d:\data\computer\entwicklung\python\matplotlib\sour
    self.draw()
  File "d:\data\computer\entwicklung\python\matplotlib\sour
    self.figure.draw(self.renderer)
  File "d:\data\computer\entwicklung\python\matplotlib\sour
    return draw(artist, renderer, *args, **kwargs)
  File "d:\data\computer\entwicklung\python\matplotlib\sour
    renderer, self, artists, self.suppressComposite)
  File "d:\data\computer\entwicklung\python\matplotlib\sour
    a.draw(renderer)
  File "d:\data\computer\entwicklung\python\matplotlib\sour
    return draw(artist, renderer, *args, **kwargs)
  File "d:\data\computer\entwicklung\python\matplotlib\sour
    mimage._draw_list_compositing_images(renderer, self, ar
  File "d:\data\computer\entwicklung\python\matplotlib\sour
    a.draw(renderer)
  File "d:\data\computer\entwicklung\python\matplotlib\sour
    return draw(artist, renderer, *args, **kwargs)
  File "d:\data\computer\entwicklung\python\matplotlib\sour
    ticks_to_draw = self._update_ticks(renderer)
  File "d:\data\computer\entwicklung\python\matplotlib\sour
    tick_tups = list(self.iter_ticks())  # iter_ticks calls
  File "d:\data\computer\entwicklung\python\matplotlib\sour
    majorLocs = self.major.locator()
  File "d:\data\computer\entwicklung\python\matplotlib\sour
    return self.tick_values(vmin, vmax)
  File "d:\data\computer\entwicklung\python\matplotlib\sour
    locs = self._raw_ticks(vmin, vmax)
  File "d:\data\computer\entwicklung\python\matplotlib\sour
    nbins = np.clip(self.axis.get_tick_space(),
  File "d:\data\computer\entwicklung\python\matplotlib\sour
    tick = self._get_tick(True)
  File "d:\data\computer\entwicklung\python\matplotlib\sour
    return XTick(self.axes, 0, '', major=major, **tick_kw)
  File "d:\data\computer\entwicklung\python\matplotlib\sour
    self.apply_tickdir(tickdir)
  File "d:\data\computer\entwicklung\python\matplotlib\sour
    self.stale = True
  File "d:\data\computer\entwicklung\python\matplotlib\sour
    self.stale_callback(self, val)
  File "d:\data\computer\entwicklung\python\matplotlib\sour
    self.axes.stale = val
  File "d:\data\computer\entwicklung\python\matplotlib\sour
    self.stale_callback(self, val)
  File "d:\data\computer\entwicklung\python\matplotlib\sour
    self.figure.stale = val
  File "d:\data\computer\entwicklung\python\matplotlib\sour
    self.stale_callback(self, val)
  File "d:\data\computer\entwicklung\python\matplotlib\sour
    if val and matplotlib.is_interactive() and not fig.canv
RecursionError: maximum recursion depth exceeded
QWidget::paintEngine: Should no longer be called
QPainter::begin: Paint device returned engine == 0, type: 1
QPainter::end: Painter not active, aborted
QWidget::paintEngine: Should no longer be called
QPainter::begin: Paint device returned engine == 0, type: 1
QPainter::end: Painter not active, aborted
QWidget::paintEngine: Should no longer be called
QPainter::begin: Paint device returned engine == 0, type: 1
QPainter::end: Painter not active, aborted
QWidget::paintEngine: Should no longer be called
QPainter::begin: Paint device returned engine == 0, type: 1
QPainter::end: Painter not active, aborted
QWidget::paintEngine: Should no longer be called
QPainter::begin: Paint device returned engine == 0, type: 1
QPainter::end: Painter not active, aborted
QWidget::paintEngine: Should no longer be called
QPainter::begin: Paint device returned engine == 0, type: 1
QPainter::end: Painter not active, aborted
QWidget::paintEngine: Should no longer be called
QPainter::begin: Paint device returned engine == 0, type: 1
QPainter::end: Painter not active, aborted
QWidget::paintEngine: Should no longer be called
QPainter::begin: Paint device returned engine == 0, type: 1
QPainter::end: Painter not active, aborted
QWidget::paintEngine: Should no longer be called
QPainter::begin: Paint device returned engine == 0, type: 1
QPainter::end: Painter not active, aborted
QWidget::paintEngine: Should no longer be called
QPainter::begin: Paint device returned engine == 0, type: 1
QPainter::end: Painter not active, aborted
QWidget::paintEngine: Should no longer be called
QPainter::begin: Paint device returned engine == 0, type: 1
QPainter::end: Painter not active, aborted
QWidget::paintEngine: Should no longer be called
QPainter::begin: Paint device returned engine == 0, type: 1
QPainter::end: Painter not active, aborted
QWidget::paintEngine: Should no longer be called
QPainter::begin: Paint device returned engine == 0, type: 1
QPainter::end: Painter not active, aborted
QWidget::paintEngine: Should no longer be called
QPainter::begin: Paint device returned engine == 0, type: 1
QPainter::end: Painter not active, aborted
QWidget::paintEngine: Should no longer be called
QPainter::begin: Paint device returned engine == 0, type: 1
QPainter::end: Painter not active, aborted
QWidget::paintEngine: Should no longer be called
QPainter::begin: Paint device returned engine == 0, type: 1
QPainter::end: Painter not active, aborted
QWidget::paintEngine: Should no longer be called
QPainter::begin: Paint device returned engine == 0, type: 1
QPainter::end: Painter not active, aborted
QWidget::paintEngine: Should no longer be called
QPainter::begin: Paint device returned engine == 0, type: 1
QPainter::end: Painter not active, aborted
QWidget::paintEngine: Should no longer be called
QPainter::begin: Paint device returned engine == 0, type: 1
QPainter::end: Painter not active, aborted
QWidget::paintEngine: Should no longer be called
QPainter::begin: Paint device returned engine == 0, type: 1
QPainter::end: Painter not active, aborted
QWidget::paintEngine: Should no longer be called
QPainter::begin: Paint device returned engine == 0, type: 1
QPainter::end: Painter not active, aborted
QWidget::paintEngine: Should no longer be called
QPainter::begin: Paint device returned engine == 0, type: 1
QPainter::end: Painter not active, aborted
QWidget::paintEngine: Should no longer be called
QPainter::begin: Paint device returned engine == 0, type: 1
QPainter::end: Painter not active, aborted
QWidget::paintEngine: Should no longer be called
QPainter::begin: Paint device returned engine == 0, type: 1
QPainter::end: Painter not active, aborted
QWidget::paintEngine: Should no longer be called
QPainter::begin: Paint device returned engine == 0, type: 1
QPainter::end: Painter not active, aborted
QWidget::paintEngine: Should no longer be called
QPainter::begin: Paint device returned engine == 0, type: 1
QPainter::end: Painter not active, aborted
QWidget::paintEngine: Should no longer be called
QPainter::begin: Paint device returned engine == 0, type: 1
QPainter::end: Painter not active, aborted
QWidget::paintEngine: Should no longer be called
QPainter::begin: Paint device returned engine == 0, type: 1
QPainter::end: Painter not active, aborted
QWidget::paintEngine: Should no longer be called
QPainter::begin: Paint device returned engine == 0, type: 1
QPainter::end: Painter not active, aborted
QWidget::paintEngine: Should no longer be called
QPainter::begin: Paint device returned engine == 0, type: 1
QPainter::end: Painter not active, aborted
QWidget::paintEngine: Should no longer be called
QPainter::begin: Paint device returned engine == 0, type: 1
QPainter::end: Painter not active, aborted
QWidget::paintEngine: Should no longer be called
QPainter::begin: Paint device returned engine == 0, type: 1
QPainter::end: Painter not active, aborted
QWidget::paintEngine: Should no longer be called
QPainter::begin: Paint device returned engine == 0, type: 1
QPainter::end: Painter not active, aborted
QWidget::paintEngine: Should no longer be called
QPainter::begin: Paint device returned engine == 0, type: 1
QPainter::end: Painter not active, aborted
QWidget::paintEngine: Should no longer be called
QPainter::begin: Paint device returned engine == 0, type: 1
QPainter::end: Painter not active, aborted
QWidget::paintEngine: Should no longer be called
QPainter::begin: Paint device returned engine == 0, type: 1
QPainter::end: Painter not active, aborted
QWidget::paintEngine: Should no longer be called
QPainter::begin: Paint device returned engine == 0, type: 1
QPainter::end: Painter not active, aborted
QWidget::paintEngine: Should no longer be called
QPainter::begin: Paint device returned engine == 0, type: 1
QPainter::end: Painter not active, aborted
QWidget::paintEngine: Should no longer be called
QPainter::begin: Paint device returned engine == 0, type: 1
QPainter::end: Painter not active, aborted
QWidget::paintEngine: Should no longer be called
QPainter::begin: Paint device returned engine == 0, type: 1
QPainter::end: Painter not active, aborted
QWidget::paintEngine: Should no longer be called
QPainter::begin: Paint device returned engine == 0, type: 1
QPainter::end: Painter not active, aborted
QWidget::paintEngine: Should no longer be called
QPainter::begin: Paint device returned engine == 0, type: 1
QPainter::end: Painter not active, aborted
QWidget::paintEngine: Should no longer be called
QPainter::begin: Paint device returned engine == 0, type: 1
QPainter::end: Painter not active, aborted
QWidget::paintEngine: Should no longer be called
QPainter::begin: Paint device returned engine == 0, type: 1
QPainter::end: Painter not active, aborted
QWidget::paintEngine: Should no longer be called
QPainter::begin: Paint device returned engine == 0, type: 1
QPainter::end: Painter not active, aborted
QWidget::paintEngine: Should no longer be called
QPainter::begin: Paint device returned engine == 0, type: 1
QPainter::end: Painter not active, aborted
QWidget::paintEngine: Should no longer be called
QPainter::begin: Paint device returned engine == 0, type: 1
QPainter::end: Painter not active, aborted
QWidget::paintEngine: Should no longer be called
QPainter::begin: Paint device returned engine == 0, type: 1
QPainter::end: Painter not active, aborted
QWidget::paintEngine: Should no longer be called
QPainter::begin: Paint device returned engine == 0, type: 1
QPainter::end: Painter not active, aborted
QWidget::paintEngine: Should no longer be called
QPainter::begin: Paint device returned engine == 0, type: 1
QPainter::end: Painter not active, aborted
QWidget::paintEngine: Should no longer be called
QPainter::begin: Paint device returned engine == 0, type: 1
QPainter::end: Painter not active, aborted
QWidget::paintEngine: Should no longer be called
QPainter::begin: Paint device returned engine == 0, type: 1
QPainter::end: Painter not active, aborted

...this is hidden, collapsable content...

With TkAgg backend, py 3.6 on windows 8.1, running the example as script runs fine without error and produces the desired plot.

Removing the line self.canvas.blit(self.ax.bbox) as proposed here, lets the script run fine in TkAgg backend as well as Qt5Agg backend.

This led me to the conclusion that, similarly to the poly_editor example, one should not try to blit inside the draw_event callback. Logically this makes sense to me because there is no reason to blit if the figure is drawn anyways shortly afterwards.

@anntzer What kind of error do you get when running this with the line in question removed? Does the same happen for the poly_editor example as it is now?

tacaswell · 2018-06-13T20:43:12Z

This is the race condition that just keeps giving....

anntzer · 2018-06-13T21:20:23Z

For me (linux/py3/tkagg), removing the line causes nothing to happen at all when attempting to drag a point.

ImportanceOfBeingErnest · 2018-06-18T14:34:16Z

Any conclusion? Should I better close this and open an issue about it?
For sure the example that crashes on Windows should not stay in the docs, unless there is a way to make it work again. I wonder why the other example would still run on both systems while there does not seem to be that much of a difference.

anntzer · 2018-06-18T19:22:22Z

I think leaving this open is just as good as opening a separate issue.

jklymak · 2018-07-03T16:51:09Z

Just marking as "Needs revision" so folks don't click on this as a PR that needs review, not as a spur to action....

ImportanceOfBeingErnest · 2018-07-03T23:10:22Z

Keeping this as an unfinished/dead PR will probably rather cause confusion once someone revisists this in the future. So, I guess I will open an issue about it one of those days.

It's currently not clear (to me) why there is even a difference between the examples being run on windows and linux and this might well point towards a bigger underlying problem.

QuLogic · 2020-04-01T02:30:43Z

I cannot reproduce any error with Qt5Agg using current master.

timhoffm · 2020-05-03T00:49:22Z

I cannot reproduce the error either with:

Python 3.7.7
PyQt5 5.9.6
matplotlib 3.1.3

@ImportanceOfBeingErnest can you test on a more recent version yourself? Otherwise I propose to close this assuming fixed tue to @QuLogic and me not being able to reproduce it.

ImportanceOfBeingErnest · 2020-05-03T08:20:54Z

The issue is still present.
Again let me mention that the same is applied to the poly_editor example which even has a comment on why:

matplotlib/examples/event_handling/poly_editor.py

Lines 88 to 90 in 2d4fcc7

    
           self.ax.draw_artist(self.line) 
        
           # do not need to blit here, this will fire before the screen is 
        
           # updated

ImportanceOfBeingErnest · 2020-05-03T08:35:43Z

No wait. This is actually fixed by #16028
Closing this.
Although I would actually be interested in knowing why the one example can live without a blit and the other not...

anntzer · 2020-05-03T09:50:44Z

Actually in my hands the path_editor example now also works on tkagg without the blit; if others can confirm that perhaps we can just remove it.

rcomer · 2024-04-01T12:04:27Z

Fix Patheditor example

79cde14

anntzer requested changes Jun 13, 2018

View reviewed changes

tacaswell added this to the v2.2.3 milestone Jun 13, 2018

dstansby added the Documentation label Jun 14, 2018

tacaswell modified the milestones: v2.2.3, v2.2-doc Jun 18, 2018

jklymak added the status: needs revision label Jul 3, 2018

ImportanceOfBeingErnest closed this May 3, 2020

ImportanceOfBeingErnest deleted the fix-patheditor-example branch May 3, 2020 08:36

QuLogic removed this from the v2.2-doc milestone May 3, 2020

anntzer mentioned this pull request May 3, 2020

Merge event_handling/{path_editor,poly_editor} examples #17314

Open

rcomer mentioned this pull request Apr 1, 2024

Segfault from path editor example with QtAgg #28002

Closed

Sunbelt Computer Software

PL/B Language Development and Support

Uh oh!

Uh oh!

Conversation

ImportanceOfBeingErnest commented Jun 13, 2018

PR Summary

Uh oh!

anntzer left a comment

Choose a reason for hiding this comment

Uh oh!

ImportanceOfBeingErnest commented Jun 13, 2018

Uh oh!

tacaswell commented Jun 13, 2018

Uh oh!

anntzer commented Jun 13, 2018

Uh oh!

ImportanceOfBeingErnest commented Jun 18, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

anntzer commented Jun 18, 2018

Uh oh!

jklymak commented Jul 3, 2018

Uh oh!

ImportanceOfBeingErnest commented Jul 3, 2018

Uh oh!

QuLogic commented Apr 1, 2020

Uh oh!

timhoffm commented May 3, 2020

Uh oh!

ImportanceOfBeingErnest commented May 3, 2020

Uh oh!

ImportanceOfBeingErnest commented May 3, 2020

Uh oh!

anntzer commented May 3, 2020

Uh oh!

rcomer commented Apr 1, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

ImportanceOfBeingErnest commented Jun 18, 2018 •

edited

Loading