{{ message }}
Figure equality-based tests. - #11408
Merged
Merged
Conversation
Member
anntzer
force-pushed
the
check_figures_equal
branch
from
June 10, 2018 21:02
2eec7e8 to
91354a1
Compare
Member
|
Seems useful. However, the new test is failing 😉 |
Contributor
Author
|
Yes, and I can't reproduce the failure locally... Can anyone else give it a try? |
Contributor
|
@anntzer I just pulled your PR branch and ran Python 3.6.4 (from conda) |
Member
|
yeah, sorry, works on my machine as well (well I skip svg) |
Member
|
Interestingly my machine is a mac and it passes on my machine, and this passes the travis Mac tests. But not the linux ones. No idea whats going on here. |
anntzer
force-pushed
the
check_figures_equal
branch
from
June 15, 2018 21:55
91354a1 to
3e16090
Compare
Implement a `check_figures_equal` decorator, which allows tests where both the reference and the test image are generated. The idea is to allow tests of the form "this feature should be equivalent to that (usually more complex) way of achieving the same thing" without further bloating the test image directory. The saved images are properly created in the `result_images` folder, but cannot be "accepted" or "rejected" using the triage_tests UI (as there is indeed no reference image to be saved in the repo). Includes an example use case.
anntzer
force-pushed
the
check_figures_equal
branch
from
June 19, 2018 17:00
3e16090 to
9cd3fbe
Compare
Contributor
Author
jklymak
approved these changes
Jun 19, 2018
timhoffm
approved these changes
Jun 23, 2018
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement a
check_figures_equaldecorator, which allows tests whereboth the reference and the test image are generated. The idea is to
allow tests of the form "this feature should be equivalent to that
(usually more complex) way of achieving the same thing" without further
bloating the test image directory.
The saved images are properly created in the
result_imagesfolder, butcannot be "accepted" or "rejected" using the triage_tests UI (as there
is indeed no reference image to be saved in the repo).
Includes an example use case. Other PRs that could use this feature
include #9426 and #11407.
PR Summary
PR Checklist