{{ message }}
Fix for scatter not showing points with valid x/y but invalid color - #10809
Closed
QiCuiHub wants to merge 3 commits into
Closed
Fix for scatter not showing points with valid x/y but invalid color#10809QiCuiHub wants to merge 3 commits into
QiCuiHub wants to merge 3 commits into
Conversation
Member
… updated - Fixed ambiguous kwarg to a more appropriate, less ambiguous name -> plotinvalid
Author
|
@jklymak you are right, we decided to change it to plotinvalid |
Member
|
The goal is reasonable; I can see the argument for using the "set_bad" color for masked or otherwise invalid points. I think the implementation will need quite a bit more thought and testing, however. As it stands, with plotinvalid=True, there is a huge change in behavior, affecting much more than the handling of colormapping: the deletion of points masked based on other variables (x, y, size, etc.) is disabled. This is related to #10381. |
… update 2 changed test_scatter_invalid_color(): where masked in ax.scatter (line 1680) => plotinvalid (line 1680)
jklymak
reviewed
Mar 29, 2018
| collection.set_array(np.asarray(c)) | ||
|
|
||
| if plotinvalid is False: | ||
| collection.set_array(c) |
Member
There was a problem hiding this comment.
can you really get away w/o the np.asarray?
Otherwise this seems to preserve the old behaviour by default and adds a useful functionality.
This will need a whats-new entry...
Member
6 tasks
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Fix for #4354 scatter points being ignored when they have a valid x,y but invalid color such as np.nan or np.inf