bug fix - set_facecolor/set_edgecolor not working for some 3D artists by xiaoshiqi · Pull Request #10797 · matplotlib/matplotlib · GitHub
Skip to content

bug fix - set_facecolor/set_edgecolor not working for some 3D artists - #10797

Closed
xiaoshiqi wants to merge 22 commits into
matplotlib:masterfrom
CinnyCao:xiaoshiqi-Wrong-Face-Color-fix
Closed

xiaoshiqi wants to merge 22 commits into
matplotlib:masterfrom
CinnyCao:xiaoshiqi-Wrong-Face-Color-fix

Conversation

@xiaoshiqi

@xiaoshiqi xiaoshiqi commented Mar 15, 2018

Copy link
Copy Markdown

PR Summary

fixed set_facecolor(set_facecolors), set_edgecolor(set_edgecolors), and set_color not working for some 3Dartists

this bug was originally mentioned in #9725
this PR is an extension of my earlier attempt #10489

PR Checklist

  • Has Pytest style unit tests
  • Code is PEP 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

… (the one cause the problem), hopefully it works
@WeatherGod

Copy link
Copy Markdown
Member

@xiaoshiqi

Copy link
Copy Markdown
Author

@WeatherGod looks like Poly3DCollection was already fixed years ago. should I change it to make the style unified?

@jklymak

jklymak commented Mar 24, 2021

Copy link
Copy Markdown
Member

@jklymak jklymak closed this Mar 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants