{{ message }}
Make markerfacecolor work for 3d scatterplots - #10693
Closed
jinshifen33 wants to merge 4 commits into
Closed
jinshifen33 wants to merge 4 commits into
jinshifen33 wants to merge 4 commits into
Conversation
Contributor
Author
timhoffm
requested changes
Mar 5, 2018
| self.stale = True | ||
|
|
||
| def set_facecolor(self, colors): | ||
| # override setter for facecolor so that 3dfacecolor |
Member
There was a problem hiding this comment.
Please use triple-quote docstrings instead of comments for documenting functions. This is the standard pep8 style we're aiming for (even if historically there are other styles in the code base).
| # In providing consitentcy in 2dcolor and 3dcolor setter. | ||
| # Note: will also update edgecolor if it follows facecolor | ||
|
|
||
| PathCollection.set_facecolor(self, colors) |
Member
There was a problem hiding this comment.
Since this will by py3 only, use super().
| self._edgecolor3d = PathCollection.get_edgecolor(self) | ||
| set_edgecolors = set_edgecolor | ||
|
|
||
| def _set_facecolors_on_project(self, colors): |
Member
There was a problem hiding this comment.
what is project? Should this rather be _set_facecolors_on_projection or _set_facecolors_on_2d_projection?
| set_edgecolors = set_edgecolor | ||
|
|
||
| def _set_facecolors_on_project(self, colors): | ||
| # A sepearted method that changes edgecolor in drawing |
| self._facecolor3d) | ||
| fcs = mcolors.to_rgba_array(fcs, self._alpha) | ||
| self.set_facecolors(fcs) | ||
| # now uses setter on project |
Member
There was a problem hiding this comment.
The comment does not add information and thus can be left out.
jklymak
changed the title
Member
|
Milestoning 3.0 because this isn't fixing a regression. |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
This pull request is a fix for issue 9725 color issue on 3D scatter plots. Invoking the set color method after the initial creation of a scatter 3D plot would not change the color; these changes fix this issue.
PR Checklist