{{ message }}
Make the filternorm prop of Images a boolean rather than a {0,1} scalar. - #10442
Merged
Merged
Conversation
Member
Contributor
Author
|
seems easy to rebase in either direction |
This seems a bit more pythonic and the C-API handles bools just as well. Also filternorm and filterrad are always defined (as bool and float, respectively, so no need to add `... or 0.0` when passing them to the C-API.
jklymak
reviewed
Apr 8, 2018
| filternorm : scalar, optional, default: 1 | ||
| A parameter for the antigrain image resize filter. From the | ||
| antigrain documentation, if `filternorm` = 1, the filter | ||
| filternorm : bool, optional, default: True |
Member
There was a problem hiding this comment.
OK, so filternorm was either 1 or zero?
The rest of this docstring doesn't make a lick of sense to me. I think they are trying to say the sum of the filter should be one, but???
Contributor
Author
There was a problem hiding this comment.
Feel free to propose a better wording :-) (it doesn't make sense to me either)
At least since #10383 matplotlib._image.resample also documents norm as a bool.
Member
|
Concerning removal of What if users have used |
Contributor
Author
timhoffm
approved these changes
Apr 8, 2018
QuLogic
approved these changes
Apr 11, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This seems a bit more pythonic and the C-API handles bools just as well.
Also filternorm and filterrad are always defined (as bool and float,
respectively, so no need to add
... or 0.0when passing them to theC-API.
PR Summary
PR Checklist