Adds a clang-tidy linter by martinus · Pull Request #145 · martinus/unordered_dense · GitHub
Skip to content

Adds a clang-tidy linter - #145

Merged
martinus merged 3 commits into
mainfrom
mla/2025-10-07/clang-tidy-linter
Oct 7, 2025
Merged

Adds a clang-tidy linter#145
martinus merged 3 commits into
mainfrom
mla/2025-10-07/clang-tidy-linter

Conversation

@martinus

@martinus martinus commented Oct 7, 2025

Copy link
Copy Markdown
Owner

No description provided.

@martinus
martinus requested a review from Copilot October 7, 2025 17:30

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a clang-tidy linter to the project to perform static analysis on the unordered_dense.h header file. The linter is integrated into the CI workflow and modernizes the codebase by applying C++ best practices and fixing various style issues.

Key changes:

  • Integrates clang-tidy linting into the CI workflow with a Python script
  • Modernizes C++ template metaprogramming using newer type traits syntax
  • Fixes various code style issues identified by clang-tidy checks

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
scripts/lint/lint-clang-tidy.py New Python script to run clang-tidy on the header file
.clang-tidy Updated configuration with comprehensive checks and proper header filtering
.github/workflows/main.yml Integrates clang-tidy into CI workflow
include/ankerl/unordered_dense.h Modernizes code with C++17 features and fixes style issues
test/unit/include_only.cpp Adds NOLINT comment to suppress include-cleaner warning

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread include/ankerl/unordered_dense.h Outdated
Comment thread include/ankerl/unordered_dense.h Outdated
@martinus
martinus force-pushed the mla/2025-10-07/clang-tidy-linter branch from 0815375 to 39c037d Compare October 7, 2025 17:49
@martinus
martinus merged commit 43fa2f3 into main Oct 7, 2025
36 checks passed
@martinus
martinus deleted the mla/2025-10-07/clang-tidy-linter branch October 7, 2025 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants