{{ message }}
Repository navigation
fix: prevent duplicate sidebar trash confirmations - #5806
Merged
Merged
Conversation
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Related: #3148 (sidebar Delete shortcut).
Summary
After the editor page remounts, one Delete / macOS Fn+Backspace can open two trash confirmation dialogs.
app.vueregistered sidebar bus handlers on every mount, but never removed them. The project store and bus survive the page, so a singleSIDEBAR::removeevent invokes both handlers and sends two identical IPC requests.Make sidebar listener registration idempotent, return a cleanup function, and unsubscribe when the editor page unmounts or the project store is disposed. Ignore repeated shortcut keydowns. The main-process confirmation flow remains unchanged; no concurrent-request deduplication is needed.
Type of change
Test plan
pnpm run lint(0 errors; existing warnings),pnpm run typecheck, andpnpm run build:unpack.By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.