{{ message }}
Repository navigation
[2/5] feat(muya): add accessible code copy and clipboard feedback - #5800
Merged
Merged
Conversation
This was referenced Oct 20, 2026
Contributor
|
Build artifacts for PR #5800: Run: https://github.com/marktext/marktext/actions/runs/39402038545 |
Jocs
force-pushed
the
split/muya-async-target-validation
branch
from
October 20, 2026 08:54
75bf891 to
3667d37
Compare
Jocs
force-pushed
the
split/muya-code-copy-feedback
branch
3 times, most recently
from
October 20, 2026 09:23
ade176c to
97454e9
Compare
Jocs
force-pushed
the
split/muya-async-target-validation
branch
from
October 20, 2026 09:23
3667d37 to
024bebe
Compare
Jocs
force-pushed
the
split/muya-code-copy-feedback
branch
from
October 20, 2026 09:25
97454e9 to
7a9f072
Compare
Jocs
force-pushed
the
split/muya-code-copy-feedback
branch
from
October 20, 2026 09:37
7a9f072 to
6e56326
Compare
Jocs
changed the base branch from
split/muya-async-target-validation
to
develop
October 20, 2026 09:37
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to #3688, #4532, #3745. Split from #5793, which stays open as layer 5.
Review stack
Review and merge in this order. Each PR targets the preceding branch, so its Files changed tab contains only its own layer.
After a preceding PR merges, retarget/rebase its successor onto
developbefore merging it. Keep intermediate branches until their downstream PR has been retargeted. #5793 is the original PR, retained and reused.Summary
Make code-block copying keyboard accessible with a native button, an accessible name and localized success/failure feedback. Add an optional clipboard writer callback that reuses the existing
window.electron.clipboard.writeText()API. Upgrade that API to returnPromise<boolean>via oneinvoke/handlepath and remove the formersend/onpath and send-channel contract. Keep the cursor regression aligned with the button element.Type of change
Test plan
Notes for reviewers
Layer 2/5 of a linear PR stack. Review the diff against this PR’s base branch; merge in order. The next layer is rebased/retargeted after this one lands.
Follow-up review
Unified resolved/rejected clipboard failure feedback, including the accessible label and timed reset. Removed copy-button visibility updates duplicated in key handlers; update() owns this state. Independent Muya suite: 2765 tests passed.
Changes remain in their owning layer; all five existing PRs are retained. Additional IME handling was deferred as requested.
By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.