{{ message }}
Repository navigation
refactor(notification): use Element Plus Notification for global notices - #5798
Merged
Merged
Conversation
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace the custom DOM toast service with Element Plus Notification while keeping the existing
notice.notify(options)API and its Promise semantics.ElNotificationwith bottom-right positioning and z-index 10100.mt-notificationselector used by tests.The per-tab inline notification banner is intentionally unchanged: it is tab-scoped persistent UI, not a global overlay.
Verification
pnpm run typecheckpnpm run test:unit(104 files, 1133 tests)The Playwright diagram-viewer spec selectors were updated. A local E2E run could not complete because an Electron dev instance was already active; CI will exercise the spec.