{{ message }}
Repository navigation
fix: #4997 theme icon tooltips and delay hover hints - #5788
Merged
Merged
Conversation
Contributor
|
Build artifacts for PR #5788: Run: https://github.com/marktext/marktext/actions/runs/39140216691 |
3 of 6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Related: #4997. Follow-up to #5739 and the review comment.
Summary
Icon tooltips added in #5739 always used Element Plus's default dark appearance and opened after only 300ms. They now follow the active MarkText theme and wait longer before appearing when the pointer passes over a control.
The existing Enter/Space handling, Escape dismissal and accessible names are preserved.
Type of change
Test plan
pnpm run build:unpack,pnpm run typecheck,pnpm run lint(no errors; existing warnings).Screenshots
Notes for reviewers
The styling is limited to
IconTooltip; it does not restyle other Element Plus popovers. The popper is teleported tobody, so its class is styled globally within the component.By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.