{{ message }}
Repository navigation
chore(desktop): drop deprecated optimizeDeps.esbuildOptions - #5738
Merged
Jocs merged 2 commits intoOct 14, 2026
Merged
Conversation
Vite 8 pre-bundles with Rolldown and warns that esbuildOptions is deprecated. The top-level define.global covers pre-bundled deps.
Member
MicoinSmith
force-pushed
the
chore/drop-vite-esbuild-options
branch
from
October 13, 2026 10:49
5556882 to
8a88511
Compare
Contributor
Author
Jocs
approved these changes
Oct 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove the deprecated
optimizeDeps.esbuildOptionsfromelectron.vite.config.ts. Vite 8 pre-bundles with Rolldown and prints adeprecation warning for this option on every dev/build run.
It cannot simply be swapped for
rolldownOptions: { define }: Vite's depoptimizer omits
definefrom its Rolldown options (tsc rejects it and Rolldownwarns "Expected never"). The existing top-level
define.globalalready coverspre-bundled dependencies, so the option is simply dropped.
Type of change
Test plan
pnpm run build:unpackcompletes with no deprecationwarning.
Notes for reviewers
Pre-bundled deps (
pako,pathe) still resolveglobalvia the top-leveldefine.