{{ message }}
Repository navigation
fix: prevent paragraph menu clipping when sidebar is hidden - #5711
Merged
Merged
Conversation
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Closes #5710
Summary
Hiding the sidebar places the paragraph button near the left edge of the window. Opening its centered menu in an 800px-wide Electron window positioned the menu at x = -56px, cutting off its left side.
Add Floating UI shift middleware after offset and flip so shared floating menus stay within the window with 8px of padding. Add an Electron regression test that hides the sidebar, checks both horizontal menu boundaries, and converts the paragraph to a heading through the menu.
Type of change
Test plan
Validation:
pnpm run build:unpack,pnpm run lint, andpnpm run typecheckpassed.By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.