{{ message }}
Repository navigation
fix(build): re-sign macOS arm64 builds after flipping the nodeCliInspect fuse - #5664
Merged
Merged
Conversation
Contributor
Jocs
force-pushed
the
fix/macos-arm64-adhoc-signing
branch
2 times, most recently
from
October 8, 2026 16:24
0e7a4a6 to
585b429
Compare
Jocs
force-pushed
the
fix/macos-arm64-adhoc-signing
branch
from
October 8, 2026 16:28
585b429 to
4cec640
Compare
Jocs
force-pushed
the
fix/macos-arm64-adhoc-signing
branch
from
October 8, 2026 16:35
4cec640 to
e608fdc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Closes #5611
Summary
Backports the v0.21.1 hotfix to
developso 0.22.0 is not affected, and corrects the macOS quarantine command in the release-note template.Crash: #5643 added
electronFuses, and flipping a fuse rewrites theElectron Frameworkbinary, invalidating the ad-hoc signature its linker wrote. The macOS build is never re-signed (skipped macOS application code signing … 0 identities found), so the v0.21.0 arm64 app was killed at launch withEXC_BAD_ACCESS (Code Signature Invalid).Fix:
resetAdHocDarwinSignature: truemakes@electron/fusesre-sign the app ad-hoc (codesign --sign - --deep) immediately after flipping the fuse.Note fix: the note told users to run
xattr -cr /Applications/marktext.app— a path that no longer exists after the app rename (#5202), so the documented command always failed. It now readsxattr -d com.apple.quarantine /Applications/MarkText.app.Type of change
Test plan
Notes for reviewers [optional]
xattr -d com.apple.quarantine <app>is preferred overxattr -cr <app>:-r, which is exactly what [Bug] For Macs, xattr commandline is incorrect... #5611 reported as unsupported (option -r not recognized), so it works whicheverxattrvariant is on the user's PATH;com.apple.quarantinewhen it is present. When the flag has already been cleared it printsNo such xattr: com.apple.quarantine— harmless, since the goal state is already reached.Verified locally on arm64:
pnpm run build:mac:arm64produces a bundle whoseElectron Frameworkverifies asvalid on disk, and the built app launches without the code-signing kill. The same change shipped as v0.21.1.By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.