{{ message }}
Repository navigation
fix: #5239 let Ctrl+Backspace delete a word at the end of a line - #5657
Merged
Jocs merged 1 commit intoOct 8, 2026
Merged
Conversation
Format.backspaceHandler removes the last character itself whenever the caret sits at the end of a token (Firefox workaround for muya#113). At the end of a line that is always true for the last text token, so the native Ctrl/Alt/Cmd+Backspace word deletion was suppressed. Leave modified Backspace to the browser, as already happens mid-line. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Jocs
added a commit
that referenced
this pull request
Oct 8, 2026
…in code blocks (#5239) #5657 let Ctrl/Alt/Cmd+Backspace reach the browser so it can delete a whole word or line. Two gaps remained. `resolveEndpoint` read the DOM offset of an element-anchored selection as a character offset. A native "delete to line start" clears the last line, leaves a trailing `<br>`, and parks the caret on the content element itself — so the surviving text `foo\n` resolved to offset 1 and the caret jumped into `foo`. Translate the child index into a text offset for that anchor. Endpoints inside a child node keep the legacy mapping, which the inline-image paths compensate for. `CodeBlockContent.backspaceHandler` owns its own token-boundary fix-up and never called `super`, so at a Prism token boundary it still intercepted the chord and trimmed one character (`const|` -> `cons x = 1` instead of ` x = 1`). Defer to the browser there too, after the offset-0 branch that converts the block to a paragraph.
Jocs
added a commit
that referenced
this pull request
Oct 8, 2026
…in code blocks (#5239) (#5658) #5657 let Ctrl/Alt/Cmd+Backspace reach the browser so it can delete a whole word or line. Two gaps remained. `resolveEndpoint` read the DOM offset of an element-anchored selection as a character offset. A native "delete to line start" clears the last line, leaves a trailing `<br>`, and parks the caret on the content element itself — so the surviving text `foo\n` resolved to offset 1 and the caret jumped into `foo`. Translate the child index into a text offset for that anchor. Endpoints inside a child node keep the legacy mapping, which the inline-image paths compensate for. `CodeBlockContent.backspaceHandler` owns its own token-boundary fix-up and never called `super`, so at a Prism token boundary it still intercepted the chord and trimmed one character (`const|` -> `cons x = 1` instead of ` x = 1`). Defer to the browser there too, after the offset-0 branch that converts the block to a paragraph.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #5239
Summary
In the WYSIWYG editor, Ctrl+Backspace at the end of a line only deletes one
character instead of the previous word. In the middle of a line it works.
Cause:
Format.backspaceHandlercontains a Firefox workaround formarktext/muya#113. Whenever the caret is exactly at the end of a token, it
removes the last character itself and calls
preventDefault(). At the end ofa line the caret is always at the end of the last (plain text) token, so the
browser's native word deletion is suppressed. Modifier keys are never checked.
The legacy muyajs editor only handled
inline_mathand<ruby>here, so 0.17was not affected.
Fix: when Ctrl, Alt or Cmd is held, return early and let the browser perform
its native word/line deletion, as it already does in the middle of a line.
Plain Backspace keeps the existing behaviour. Backspace at offset 0 (block
merge) is handled before this code and is unaffected.
Type of change
Test plan
formatBackspace.spec.ts, fail without the fix)Notes for reviewers
Ctrl+Backspace directly after inline markup (e.g.
**strong**|) is now alsohandled natively, the same way it already is in the middle of a line.