{{ message }}
Repository navigation
revert: keep grayscale antialiasing on editor text (#5539) - #5558
Merged
Merged
Conversation
Reverts the second half of #5553. Restoring the platform default made text too heavy on macOS, where there is no system subpixel antialiasing to gain back — `auto` only changes stem weight there, and the maintainer prefers the lighter look. The code block colour fix is unaffected and stays: it is what made the text legible, and it is independent of how glyphs are rasterised. Drop the spec's smoothing assertion, which encoded the opposite decision. This leaves the reporter's crispness complaint open on Windows, where `auto` does restore LCD subpixel rendering. Scoping the declaration per platform is the obvious follow-up if we want both. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Contributor
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts the second half of #5553. Refs #5539.
Restoring the platform default made text too heavy on macOS, which is where this was evaluated. There is no system subpixel antialiasing to gain back there — Core Graphics dropped it in Mojave — so
autoonly changes stem weight, and the lighterantialiasedlook is preferred.The code block colour fix stays. That is what made the text legible, and it is independent of how glyphs are rasterised; the four theme colour assertions still pass. Only the spec's smoothing assertion goes, since it encoded the opposite decision.
What this leaves open
On Windows — which is almost certainly the reporter's platform —
autodoes restore LCD subpixel rendering, andantialiasedthrows it away. Their 0.19 screenshot's body text carries pixels like#5778a9,#90c9fa,#fae2ae: three channels varying independently around#575f66, the signature of subpixel coverage. On 0.20-rc.6 the same text is neutral grey (#7e8489,#c6c9cb). So their "0.20 看起来模糊" is not addressed by this PR, only their contrast complaint is.If we want both, the declaration can be scoped so macOS keeps
antialiasedand the other platforms getauto. Happy to do that as a follow-up — say the word.4 tests, all passing locally.
🤖 Generated with Claude Code