{{ message }}
Repository navigation
test: fold the two #5539 specs into one - #5557
Merged
Merged
Conversation
The smoothing check was a whole spec file, and a second Electron launch, for a single assertion that one declaration is absent. Move it next to the code block colour cases, which already launch the app and switch themes, and rename the file to match what it now covers. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #5553. Refs #5539 — no behaviour change, tests only.
#5553 shipped two spec files. The second one,
issue-5539-text-smoothing.spec.ts, was 38 lines and a whole extra Electron launch to assert that a single CSS declaration is absent. The colour cases already launch the app and switch themes, so the assertion belongs there.issue-5539-code-block-contrast.spec.ts→issue-5539-text-legibility.spec.ts(it covers more than contrast now)issue-5539-text-smoothing.spec.tsdeleted, its assertion folded in as a fifth testThe smoothing check is worth keeping in some form: muya tracks an upstream that still ships
-webkit-font-smoothing: antialiased, so a sync can silently reintroduce it. The comment in the spec says so.Verified it still fails for the right reason: re-adding the declaration to
packages/muya/src/assets/styles/index.cssand rebuilding turns exactly that one test red (Expected: "auto",Received: "antialiased"), with the four colour tests still green. Theme stylesheets never touch-webkit-font-smoothing, so running the assertion after four theme switches in the same window is safe.5 tests, one launch, all passing locally.
🤖 Generated with Claude Code