{{ message }}
Repository navigation
ci: bound the unit-test job at ten minutes - #5448
Merged
Merged
Conversation
The job sets no timeout and so inherits GitHub's 360-minute default, unlike muya-spec.yml (15) and muya-e2e.yml (20). Since #5323 it also runs on windows-latest, the platform where a worker that never exits is most likely — an unreleased file watcher or an EBUSY rename, the same fs semantics that already force `it.skipIf(process.platform === 'win32')` in write-file-atomic.spec.ts. One hang would leave the check pending for six hours while the Linux leg reports green beside it, which reads as a slow queue rather than a failure, and would hold a concurrency slot shared with every other PR. `cancel-in-progress` only frees it once someone pushes again. Ten minutes is four times the slowest run observed so far (2m25s on Windows, 56s on Linux). Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #5323, which added a
windows-latestleg to the unit-test matrix.The
testjob sets notimeout-minutesand so inherits GitHub's 360-minute default. The repo's other long-running workflows do set one —muya-spec.ymluses 15 andmuya-e2e.ymluses 20 — this job was simply never given one back when it was a single 56-second Linux job.It now also runs on Windows, which is the platform where a worker that never exits is most plausible: an unreleased file watcher, an
EBUSYrename, the same fs semantics that already forceit.skipIf(process.platform === 'win32')inwrite-file-atomic.spec.ts:65.If that happens once, the consequences are out of proportion to the cause:
test (windows-latest)stays pending for six hours whilefail-fast: falselets the Linux leg report green beside it, so the PR shows half green / half spinning — which reads as a slow queue, not a failure;cancel-in-progressonly frees it when someone pushes to the same branch again; otherwise it takes a manual cancel.timeout-minutes: 10turns all of that into a clear red check ten minutes in. That is four times the slowest run observed so far (2m25s onwindows-latest, 56s onubuntu-latest), so it leaves ample headroom for a cold pnpm cache.Type of change
🤖 Generated with Claude Code