{{ message }}
Repository navigation
fix(desktop): open Quick Open when files are open without a folder - #5431
Merged
Jocs merged 1 commit intoSep 17, 2026
Merged
Conversation
1 task done
Jocs
approved these changes
Sep 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Fixes #5430
Summary
With a file open and no folder, Quick Open (Ctrl+P) never showed the palette.
QuickOpenCommand.run()lets that state through on purpose (it only gives up when there is neither a folder nor a tab), then lists the open tabs through_getPath(), which readthis._folderState.projectTree!.pathname.projectTreeisnullin that state, sorun()rejected with a TypeError andhandleShowonly logged it._getPath()now treats a missing folder like a file outside the folder and returns the full path as title and description, which is what it already did for files outside the opened folder. Nothing changes when a folder is open._doSearch()already handled the no-folder case on its own, sorun()was the only path that failed.Type of change
Test plan
packages/desktop/test/unit/specs/quick-open-without-folder.spec.tscallsrun()with one open tab (plus an untitled one), first with no folder and then with a folder that contains the file. Ondevelop(73b90a7) the no-folder case fails withpromise rejected "TypeError: Cannot read properties of null…" instead of resolving, thrown atquickOpen.ts:216. With the fix both tests pass. The whole desktop unit suite passes (60 files, 820 tests),vue-tsc --noEmitis clean, and eslint reports no errors on the two files. I ran this on Linux under vitest and did not try the shortcut in a built app.Notes for reviewers [optional]
The same file builds the tab filter RegExp from a
SPECIAL_CHARSclass that leaves out{and}, like the Find escaping fixed in #5428. I kept that out of this PR.By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.
Found by a defect-hunting pipeline I build and run (Dev-next-gen), using Claude Code with Anthropic's Claude Opus 5.