{{ message }}
Repository navigation
fix(muya): preserve drive/UNC roots in relative image path resolution (#4428 review follow-up) - #4430
Merged
Merged
Conversation
The Phase G #4428 relative-image resolver collapsed `..` past the root, dropping the Windows drive segment (`C:/a/../../b` -> `b`, losing `C:`) and mangling UNC `//server/share` bases. Isolate the root (UNC share / drive / POSIX) before resolving and never collapse past it, mirroring path.resolve. Adds 6 drive/UNC regression cases. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Fix-forward to packages/muya’s relative image path resolver so Windows drive roots (C:) and UNC share roots (//server/share) are preserved and .. traversal is clamped at the root (mirroring path.resolve behavior), preventing root segments from being collapsed away during normalization.
Changes:
- Update
resolveRelativePathto isolate and preserve UNC share / drive roots and prevent..from collapsing past them. - Add regression tests covering drive preservation, drive-root clamp, backslash normalization, UNC share handling, and UNC-root clamp.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix-forward for a Copilot comment that landed on #4428 after merge. The new
resolveRelativePathcollapsed..past the root: a Windows drive (C:/a/../../blost theC:segment) and UNC//server/shareroots got mangled. Now the root (UNC share / drive / POSIX) is isolated and never collapsed past, mirroringpath.resolve. +6 regression cases (drive preservation, drive-root clamp, backslash normalisation, UNC share, backslash-UNC, UNC-root clamp). lint/lint:types/test green.