fix(website): open download buttons in new tab pointing to releases page by Jocs · Pull Request #4336 · marktext/marktext · GitHub
Skip to content

fix(website): open download buttons in new tab pointing to releases page - #4336

Merged
Jocs merged 1 commit into
developfrom
fix/website-download-links-releases
May 31, 2026
Merged

Jocs merged 1 commit into
developfrom
fix/website-download-links-releases

Conversation

@Jocs

@Jocs Jocs commented May 31, 2026

Copy link
Copy Markdown
Member

Summary

  • Nav-bar Download button used to scroll to the in-page download section; it now opens the GitHub releases page in a new tab.
  • The three platform tiles in the landing-page download section (macOS / Windows / Linux) used to link directly to the latest-release asset URLs (.dmg / .exe / .AppImage). They now all open the releases page in a new tab so visitors can pick the right asset for their CPU/architecture themselves.
  • All four targets now use the already-defined DOWNLOAD.releases constant (https://github.com/marktext/marktext/releases).

Test plan

  • pnpm --filter marktext-website dev, open the landing page, click the nav-bar Download button — verify it opens https://github.com/marktext/marktext/releases in a new tab.
  • Scroll to the "Free download" section; click each of the macOS / Windows / Linux tiles — verify each opens the releases page in a new tab.
  • Confirm no other links on the page changed behavior.

🤖 Generated with Claude Code

… new tab

The nav-bar Download button used to scroll to the in-page download
section; the three platform tiles linked directly to the latest-release
asset URLs (.dmg/.exe/.AppImage). All four now open the GitHub releases
page in a new tab so visitors can pick the right asset for their
platform and architecture themselves.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings May 31, 2026 14:21

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the MarkText website’s download CTAs to consistently open the GitHub Releases page in a new tab, letting users choose the correct asset (CPU/architecture) rather than deep-linking platform-specific binaries.

Changes:

  • Nav-bar Download button now links to DOWNLOAD.releases and opens in a new tab.
  • macOS/Windows/Linux tiles in the landing-page download section now all link to DOWNLOAD.releases and open in a new tab.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
packages/website/src/components/Nav.tsx Switches the nav Download CTA from in-page anchor to the GitHub releases page in a new tab.
packages/website/src/components/Download.tsx Updates platform tile links to point to the releases page in a new tab instead of direct latest-asset URLs.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions

Copy link
Copy Markdown
Contributor

Website preview ready: https://pr-4336-marktext-website.ransixi.workers.dev

Built from 8e0bcdd11b1888ef8d294c57353e46ddd143c12b · Worker: marktext-website · Version: 4d195090-923b-4e59-8ff5-00ac82369296 · Alias: pr-4336

@github-actions

Copy link
Copy Markdown
Contributor

Build artifacts for PR #4336:

Run: https://github.com/marktext/marktext/actions/runs/26715138274

Artifact Size Link
marktext-windows-arm64 270.6 MB Download
marktext-linux 592.9 MB Download
marktext-macos-x64 271.7 MB Download
marktext-windows-x64 271.9 MB Download
marktext-macos-arm64 261.4 MB Download

@Jocs
Jocs merged commit 4a18948 into develop May 31, 2026
12 checks passed
@Jocs
Jocs deleted the fix/website-download-links-releases branch May 31, 2026 14:34
thimbleberrysystems pushed a commit to thimbleberrysystems/WordBird that referenced this pull request Jun 21, 2026
… new tab (marktext#4336)

The nav-bar Download button used to scroll to the in-page download
section; the three platform tiles linked directly to the latest-release
asset URLs (.dmg/.exe/.AppImage). All four now open the GitHub releases
page in a new tab so visitors can pick the right asset for their
platform and architecture themselves.

Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants