Fix #153 Cover image doesn't show up with epub in iBooks by clemlatz · Pull Request #237 · marijnh/Eloquent-JavaScript · GitHub
Skip to content

Fix #153 Cover image doesn't show up with epub in iBooks#237

Merged
marijnh merged 2 commits into
marijnh:masterfrom
clemlatz:patch-1
Nov 21, 2017
Merged

Fix #153 Cover image doesn't show up with epub in iBooks#237
marijnh merged 2 commits into
marijnh:masterfrom
clemlatz:patch-1

Conversation

@clemlatz

@clemlatz clemlatz commented Nov 21, 2017

Copy link
Copy Markdown

iBooks needs the following meta tag:

<meta name="cover" content="image.cover.png" />

in content.opf in order to display the cover.

Fixes #153

@marijnh

marijnh commented Nov 21, 2017

Copy link
Copy Markdown
Owner

@clemlatz

Copy link
Copy Markdown
Author

You're absolutely right. I fixed that.

@marijnh marijnh merged commit 1dfced6 into marijnh:master Nov 21, 2017
@marijnh

marijnh commented Nov 21, 2017

Copy link
Copy Markdown
Owner

Thanks. Merged. The epub on the website is in the process of being rebuilt.

@esparkman

Copy link
Copy Markdown

I still see the issue when downloading the ePub from the website and load it into iBooks.

@marijnh

marijnh commented Nov 21, 2017

Copy link
Copy Markdown
Owner

Is the meta tag there when you unzip the book? It should be. If it doesn't help, the problem diagnosis may have been wrong in the first place?

@esparkman

Copy link
Copy Markdown

I'll verify. One sec.

@esparkman

esparkman commented Nov 21, 2017

Copy link
Copy Markdown
Line 75:     <item id="image.cover.png" href="img/cover.png" media-type="image/png"/>

@marijnh

marijnh commented Nov 21, 2017

Copy link
Copy Markdown
Owner

Could you clarify?

@esparkman

Copy link
Copy Markdown

That is on Line 75 of the content.opf. When I manually pulled and compiled the file it worked just fine.

@clemlatz

Copy link
Copy Markdown
Author

@clemlatz clemlatz deleted the patch-1 branch November 22, 2017 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants