Implement cancel draggable during onAnnotationDrag by Ph0tonic · Pull Request #1129 · mapbox/mapbox-plugins-android · GitHub
Skip to content

Implement cancel draggable during onAnnotationDrag #1129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Ph0tonic wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Implement cancel draggable during onAnnotationDrag #1129

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion ...rc/main/java/com/mapbox/mapboxsdk/plugins/testapp/activity/annotation/CircleActivity.java
View file
Open in desktop
3 changes: 2 additions & 1 deletion ...rc/main/java/com/mapbox/mapboxsdk/plugins/testapp/activity/annotation/SymbolActivity.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,12 +142,13 @@ public void onAnnotationDragStarted(Symbol annotation) {
}

@Override
public void onAnnotationDrag(Symbol annotation) {
public boolean onAnnotationDrag(Symbol annotation) {
draggableInfoTv.setText(String.format(
Locale.US,
"ID: %s\nLatLng:%f, %f",
annotation.getId(),
annotation.getLatLng().getLatitude(), annotation.getLatLng().getLongitude()));
return true;
}

@Override
Expand Down
7 changes: 6 additions & 1 deletion .../src/main/java/com/mapbox/mapboxsdk/plugins/annotation/DraggableAnnotationController.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,13 +101,18 @@ boolean onMove(MoveGestureDetector detector) {
);

if (shiftedGeometry != null) {
Geometry oldGeometry = draggedAnnotation.geometry;
draggedAnnotation.setGeometry(
shiftedGeometry
);
annotationManager.internalUpdateSource();
if (!annotationManager.getDragListeners().isEmpty()) {
for (D d : annotationManager.getDragListeners()) {
d.onAnnotationDrag(draggedAnnotation);
if (!d.onAnnotationDrag(draggedAnnotation)) {
draggedAnnotation.setGeometry(oldGeometry);
stopDragging(draggedAnnotation);
return true;
}
}
}
return true;
Expand Down
3 changes: 2 additions & 1 deletion ...ation/src/main/java/com/mapbox/mapboxsdk/plugins/annotation/OnAnnotationDragListener.java
View file
Open in desktop