This allows Node 9 to be used#211
Conversation
It also removes Node 7 from the test-matrix (even though technically we can support it), so we can focus on the important versions. 7 has been superceded by 8 and is not maintained (ie: use at your own risk).
|
A new version of node-pre-gyp has been released, but I don't think node-sqlite3 uses it yet. |
|
At first glance it appears like we should be able to safely ignore those. Can you confirm? |
|
Alternatively we can wait until #180 is completed and merged. |
|
Whichever lands first I guess :) While safe to ignore, it marks all builds as broken from hereon. I don't think that's really desirable. |
|
I believe I mentioned this to you last time we had this issue, but you can ignore those errors by adding entries to the .retireignore file. |
|
Ah yes indeed, but what will trigger us to pull it out again? Or should we make a rule of adding all dev dependencies to .retireignore? |
|
We are probably better off adding problematic dependencies that can safely be ignored on a case-per-case basis. We should aim at ignoring as little as possible. |
|
Progress being made on sqlite3: TryGhost/node-sqlite3#952 |
ronkorving
force-pushed
the
allow-node-9
branch
from
5b2336b to
cbbfd0b
Compare
|
I've suppressed "low" level security warnings. Maybe that will do for now. I couldn't get exceptions to work:
|
|
https://github.com/mapbox/node-sqlite3/blob/master/CHANGELOG.md#400 :) |
2 participants
It also removes Node 7 from the test-matrix (even though technically we can support it), so we can focus on the important versions. 7 has been superceded by 8 and is not maintained (ie: use at your own risk).
This bump was previously prevented by sqlite3 not being compatible with Node 9. It is now, however, so this PR bumps the sqlite3 version accordingly.
Closes #204