Feature Request:GBase8s DB #258 add support GBase8s DB by 617206652 · Pull Request #267 · madelson/DistributedLock · GitHub
Skip to content

Feature Request:GBase8s DB #258 add support GBase8s DB#267

Open
617206652 wants to merge 2 commits into
madelson:masterfrom
617206652:master
Open

Feature Request:GBase8s DB #258 add support GBase8s DB#267
617206652 wants to merge 2 commits into
madelson:masterfrom
617206652:master

Conversation

@617206652

@617206652 617206652 commented Jan 16, 2026

Copy link
Copy Markdown

Overview:
This PR adds support for the GBase8s database.

Key Changes:
Added the GBase8s dialect directory, and the framework has also incorporated the processing procedures for GBase8s.

Related Issue: #258.

Components required for the Windows:
https://www.gbase.cn/download/gbase-8s-1?category=DRIVER_PACKAGE
download:clientsdk_3.6.3_3X3_1_ee39df_WIN2003_x86_32.ZIP

Checklist:
Local tests passed.

No breaking changes identified.

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should not be included

</PropertyGroup>

<ItemGroup>
<PackageReference Include="GeneralData.GBase8s.DataProvider" />

@madelson madelson Jan 17, 2026

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove

<CentralPackageTransitivePinningEnabled>true</CentralPackageTransitivePinningEnabled>
</PropertyGroup>
<ItemGroup>
<PackageVersion Include="GeneralData.GBase8s.DataProvider" Version="1.0.0.1" />

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This library isn't well-established enough for use here (< 1K downloads, < 2 months old).

Looks like Odbc seems to be the more common pattern for GBase interactions in the NuGet world

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sorry for the delayed reply. I've been busy with project matters recently and didn't handle your response in time.

Our product was only recently published on NuGet, but it has actually been in use for a long time. The reason is that our product was not allowed to be released publicly on the internet before. Now, to improve our ecosystem, we have pushed it out recently.

Console.WriteLine(ex.StackTrace);
foreach (GbsError err in ((GbsException)ex).Errors)
{
Console.WriteLine("Native Error" + err.NativeError);

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove all Console logs

@madelson

Copy link
Copy Markdown
Owner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants