{{ message }}
Add Markdown footnote support to from_markdown - #56
Merged
Conversation
Parse standard Markdown footnotes (`text[^label]` references and `[^label]: definition` lines) into Substack's footnoteAnchor inline nodes and footnote blocks. Footnotes are numbered by order of first reference and labels may be numeric or named. Also adds Post.footnote_anchor() and Post.footnote() helpers for building footnotes manually, plus tests.
Owner
Footnote definition extraction now skips fenced code blocks, and anchor injection skips codeBlock nodes and text marked as inline code. This fixes footnote-like text inside code being removed or rewritten. Adds regression tests for fenced and inline code cases.
Contributor
Author
|
Good catch, thanks. Fixed in 698e098:
All three regression tests you provided are included and pass (full post suite green: 66 passed). |
Footnote definitions can now contain multiple paragraphs (a blank line followed by an indented block); previously a second paragraph leaked into the post body and only the first was kept. Extraction preserves paragraph breaks and Post.footnote() splits blank-line-separated content into multiple paragraph nodes (verified accepted/rendered by Substack). Adds regression tests.
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Parse standard Markdown footnotes (
text[^label]references and[^label]: definitionlines) into Substack'sfootnoteAnchorinline nodes and footnote blocks.Footnotes are numbered by order of first reference and labels may be numeric or named.
Also adds
Post.footnote_anchor()andPost.footnote()helpers for building footnotes manually, plus tests.