Fixed issue #10 : LSC process hangs indefinitely when ouput overflow the available buffer by soisik · Pull Request #11 · lsc-project/lsc-executable-plugin · GitHub
Skip to content

Fixed issue #10 : LSC process hangs indefinitely when ouput overflow the available buffer#11

Merged
soisik merged 2 commits into
lsc-project:masterfrom
Worteks:fix-issue-10-buffer-script-output-read
Mar 6, 2019
Merged

Fixed issue #10 : LSC process hangs indefinitely when ouput overflow the available buffer#11
soisik merged 2 commits into
lsc-project:masterfrom
Worteks:fix-issue-10-buffer-script-output-read

Conversation

@soisik

@soisik soisik commented Mar 5, 2019

Copy link
Copy Markdown
Contributor

See #10 for details.
Tested using the scripts that are used in unit tests with 10 000 users in directory.

@coudot coudot requested a review from a team March 5, 2019 10:00

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not simply using IOUtils.toString?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good point, I've changed it to use IOUtils.toString

@soisik soisik added this to the 1.1 milestone Mar 6, 2019
@soisik soisik added the bug label Mar 6, 2019
@soisik soisik merged commit 9c17024 into lsc-project:master Mar 6, 2019
@soisik soisik deleted the fix-issue-10-buffer-script-output-read branch March 6, 2019 08:25
@soisik soisik self-assigned this Mar 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants