{{ message }}
Tab migration#556
Merged
Merged
Conversation
Collaborator
Collaborator
marionbarker
approved these changes
Mar 20, 2026
marionbarker
left a comment
marionbarker
left a comment
Collaborator
There was a problem hiding this comment.
Approve from code review and test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix snoozer tab disappearing when upgrading from main to dev.
The
snoozerPositionkey never existed in UserDefaults on main (snoozer was hardcoded at position 3). On dev, the StorageValue default forsnoozerPositionis.menu, so an unstored value silently becomes.menuand snoozer drops out of the tab bar.Additionally,
nightscoutPositionmay not have been stored on main (step 2 set it to the same value as the default), causing it to pick up dev's different default (.position3) and collide with where snoozer needs to go.Changes:
snoozerPosition.existsto detect users coming from main, and restore snoozer to position 3 after evicting any unstored occupantmigrationStep < 3migratePositionExists(for:)helper scoped to migration code