{{ message }}
Repository navigation
fix: show clear heading after slash heading - #13818
Draft
tiensonqin wants to merge 1 commit into
Draft
tiensonqin wants to merge 1 commit into
tiensonqin wants to merge 1 commit into
Conversation
The slash menu hid Clear heading from the edit snapshot taken when editing started. /h1 writes the heading on the live block, so the next slash menu follows that heading. Co-authored-by: tiensonqin <tiensonqin@gmail.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The slash menu decides whether to show Clear heading from the block stored when editing starts.
/h1writes:logseq.property/headingon the live block and leaves that snapshot unchanged, so the next/in the same edit still hides Clear heading.The menu now reads the live block heading. A snapshot that is still loading falls back to the edit block. Clearing the heading in the same session hides the command again.
frontend.components.editor-testcovers a heading added during the edit, a heading cleared during the edit, auto heading, and the loading fallback.Slash menu shows Clear heading after Heading 1
Slash menu hides Clear heading on a normal block
slash-clear-heading-demo.mp4
To show artifacts inline, enable in settings.