{{ message }}
Repository navigation
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Navigation can unmount the source editor before save completion, causing cleanup to skip stale editing state.
1 open issue
What changed in this PR
Unifies editor exits around saving the current input while preserving any newly opened editor.
Changes:
- Routes outside clicks, block switches, and page-reference navigation through shared exit handling.
- Separates Escape handling from outside-click handling.
- Adds draft-persistence coverage and improves a navigation assertion.
Review effort: Balanced
tiensonqin
force-pushed
the
fix/unify-editor-exit
branch
from
October 19, 2026 10:01
4846448 to
69459d9
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Route outside clicks, block switching, and page-reference navigation through the same save-and-exit flow. Each path now flushes the current input before clearing editing state, while preserving any editor opened during the save.
Separate outside-click and Escape event handling, and remove the unused exit callback and obsolete test.
Validation