{{ message }}
fix: arrow keys skip empty icon bottom-property row - #13166
Open
tiensonqin wants to merge 2 commits into
Open
Conversation
Icon-only blocks were classified as block-below and mounted an empty focusable row. Filter icon out before mounting that row, and look up bottom-property rows by the owning block uuid so parents do not steal a child's row. Co-authored-by: Tienson Qin <tiensonqin@gmail.com>
Move the owned-row query after node-attr so cljs and kondo can resolve the helper used to read blockid. Co-authored-by: Tienson Qin <tiensonqin@gmail.com>
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
It changes core editor keyboard-navigation behavior and UI mounting logic, and I couldn’t perform runtime interaction verification in this review context.
Pull request overview
This PR fixes an editor keyboard-navigation edge case where icon-only blocks could mount an invisible .bottom-properties-row that became an unintended arrow-key navigation stop, and where parent blocks could mistakenly resolve a descendant’s bottom row.
Changes:
- Filter
:logseq.property/iconout of block-below “bottom pill” rendering and avoid mounting the bottom-properties row when there are no visible pills and no bottom-row controls. - Make bottom-row lookup in the editor target the row owned by the current block via
data-bottom-properties-row="<block-uuid>", preventing parent/child row collisions. - Add focused tests covering icon-only behavior, correct row ownership resolution, and ensuring real pills (e.g. Scheduled) still render.
File summaries
Review details
- Files reviewed: 4/4 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes logseq/db-test#1145
Icon-only blocks were classified as
:block-below(:logseq.property/iconis a:map) and mounted an empty.bottom-properties-row(tab-index -1). That invisible row became a Down stop, andbottom-properties-row-in-blockused.querySelector(".bottom-properties-row"), so Up from a child icon block could match the child's row inside the parent.This change:
:logseq.property/iconout of the block-below list before mounting the row, and skips the row when there are no visible pills and no expand / add-property / hidden-properties controls[data-bottom-properties-row="<uuid>"]so a parent never owns a child's rowTests cover icon-only blocks not emitting a nav stop, parent lookup ignoring a child's row, and scheduled still rendering on the bottom row.
Lint and tests:
bb lint:devpassed (clj-kondo 0 errors / 0 warnings, carve, large-vars, worker/frontend split, translations, ns-docstrings)pnpm cljs:testcompiled with 0 warningsfrontend.components.block.positioned-properties-testandfrontend.handler.editor-test: 86 tests, 230 assertions, 0 failures