{{ message }}
fix: keep table search mounted during view-data refetch - #13132
Open
tiensonqin wants to merge 1 commit into
Open
fix: keep table search mounted during view-data refetch#13132tiensonqin wants to merge 1 commit into
tiensonqin wants to merge 1 commit into
Conversation
Table search remounted when use-resource cleared view-data, which reset the local show-input? state. Keep the last successful payload while a refetch is in flight and leave the input open whenever a query is set. Co-authored-by: Tienson Qin <tiensonqin@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Fixes db-test#1118.
Problem
In a DB-graph Table view, opening search and typing caused the input to unmount after the 300ms debounce. The filter still applied, but the field collapsed back to the magnifying-glass button.
loaded-view-auxputsdebounced-inputintoview-resource-context. When that value changes,use-resourcerefetches andview-databecomesnil. The component then swapped the entireview-container(including the search toolbar) for skeletons.searchkeepsshow-input?in local React state, so remounting reset it tofalse.Change
view-datawhile a refetch is in flight (stale-while-revalidate). Skeletons are used only on the initial load, when there is no previous payload.Test plan
bb dev:test -v frontend.components.views-testview-datanil still shows skeletons and does not mountview-container.