{{ message }}
Repository navigation
fix(kubelet-proxy): support IPv6 node service addresses - #4169
Open
immanuwell wants to merge 1 commit into
Open
immanuwell wants to merge 1 commit into
immanuwell wants to merge 1 commit into
Conversation
blacksoxx
reviewed
Oct 22, 2026
blacksoxx
left a comment
blacksoxx
left a comment
There was a problem hiding this comment.
Thanks for the fix. I checked out the branch: go test ./pkg/server/filters/ is green, vet and gofmt are clean, and against main's nodename.go the IPv6 case of TestNodeNameFromIPHost fails with an empty node name while IPv4 passes, which is exactly the bug. net.SplitHostPort returns the address without the brackets, so both the IndexByHostName lookup on the virtual nodes and the IndexByClusterIP lookup on the node Services see the same form the objects store. A Host header without a port is skipped as before, since the old code required exactly two parts.
Looks good to me.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What issue type does this pull request address?
/kind bugfix
What does this pull request do? Which issues does it resolve?
IPv6 kubelet requests use hosts like
[fd00::1234]:10250.Splitting on
:skips the node Service lookup, so metrics-server gets403 ForbiddenThis uses
net.SplitHostPortand adds IPv4 and IPv6 regression testsReproduce in an IPv6-only Kind cluster: enable
sync.fromHost.nodes.enabledandnetworking.advanced.proxyKubelets.byIP, install metrics-server, then runkubectl top nodesPlease provide a short message that should be published in the vcluster release notes
Fixed kubelet proxy routing for IPv6 node Service addresses.
What else do we need to know?
Tested with
go test -race ./pkg/server/filters -count=1and an IPv6-only Kind cluster.E2E Tests
Additional test suites
Additional test suite(s) that will be executed before the mandatory PR suite: