{{ message }}
Repository navigation
Conversation
enable use of this in docs build Signed-off-by: Jason T. Brown <jason@astraea.earth>
This reverts commit a3e265d.
…Setup develop Signed-off-by: Jason T. Brown <jason@astraea.earth>
vpipkt
changed the title
vpipkt
added
build
vpipkt
marked this pull request as ready for review
December 23, 2020 16:35
vpipkt
commented
Dec 23, 2020
vpipkt
left a comment
vpipkt
left a comment
Member
Author
There was a problem hiding this comment.
i'd like to get this merged before it gets real stale.
Member
Author
There was a problem hiding this comment.
It seems like it would be good to have something like this:
pySetup.toTask(" develop"),
Try(pySetup.toTask(" pweave")),
pySetup.toTask(" develop --uninstall")
So that the environment is put back how it was (more or less?) after the pweave task runs even if it fails.
That's beyond my sbt fu though
Member
Author
There was a problem hiding this comment.
Another possibility is a much larger refactor:
- set up tox in pyrasterframes
- separate environments for unit tests and docs builds
- sbt task runs
tox -e $TOX_ENVIRONMENTinstead ofpython setup.py $SETUP_COMMAND
This would afford a chance to also carve out many of the setup_requires and declare specific requirements files for the disctinct tox environments.
There is possibly some downside I am not thinking of (other than the work of refactoring), but it occurred to me that this might be a good direction
vpipkt
marked this pull request as draft
December 23, 2020 17:48
Member
Author
metasim
force-pushed
the
develop
branch
2 times, most recently
from
January 7, 2021 14:50
844c524 to
a5c6446
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.