localstack · joe4dev · Nov 23, 2023 · Nov 20, 2023 · Nov 20, 2023 · Nov 20, 2023
diff --git a/localstack/config.py b/localstack/config.py
@@ -904,7 +904,7 @@ def populate_edge_configuration(
 )
 # PUBLIC: documented upon customer request
 LAMBDA_LIMITS_CREATE_FUNCTION_REQUEST_SIZE = int(
-    os.environ.get("LAMBDA_LIMITS_CREATE_FUNCTION_REQUEST_SIZE", 69_905_067)
+    os.environ.get("LAMBDA_LIMITS_CREATE_FUNCTION_REQUEST_SIZE", 70_167_211)
 )
 # SEMI-PUBLIC: not actively communicated
 LAMBDA_LIMITS_MAX_FUNCTION_ENVVAR_SIZE_BYTES = int(

diff --git a/localstack/services/lambda_/api_utils.py b/localstack/services/lambda_/api_utils.py
@@ -23,10 +23,10 @@
     LayerVersionContentOutput,
     PublishLayerVersionResponse,
     ResourceNotFoundException,
-    Runtime,
     TracingConfig,
     VpcConfigResponse,
 )
+from localstack.services.lambda_.runtimes import ALL_RUNTIMES, VALID_LAYER_RUNTIMES, VALID_RUNTIMES
 from localstack.utils.collections import merge_recursive
 
 if TYPE_CHECKING:
@@ -92,31 +92,6 @@
 # Date format as returned by the lambda service
 LAMBDA_DATE_FORMAT = "%Y-%m-%dT%H:%M:%S.%f+0000"
 
-# An unordered list of all Lambda runtimes supported by LocalStack.
-# Has to contain all elements of lambda_mapping.IMAGE_MAPPING.
-RUNTIMES = [
-    Runtime.nodejs12_x,
-    Runtime.nodejs14_x,
-    Runtime.nodejs16_x,
-    Runtime.nodejs18_x,
-    Runtime.python3_7,
-    Runtime.python3_8,
-    Runtime.python3_9,
-    Runtime.python3_10,
-    Runtime.python3_11,
-    Runtime.ruby2_7,
-    Runtime.ruby3_2,
-    Runtime.java8,
-    Runtime.java8_al2,
-    Runtime.java11,
-    Runtime.java17,
-    Runtime.dotnetcore3_1,
-    Runtime.dotnet6,
-    Runtime.go1_x,
-    Runtime.provided,
-    Runtime.provided_al2,
-]
-
 # An unordered list of all Lambda CPU architectures supported by LocalStack.
 ARCHITECTURES = [Architecture.arm64, Architecture.x86_64]
 
@@ -609,11 +584,9 @@ def parse_layer_arn(layer_version_arn: str) -> Tuple[str, str, str, str]:
     )
 
 
-# TODO: use list of valid runtimes from botocore through validators. See:
-#  https://github.com/localstack/localstack/pull/7675#discussion_r1107777058
 def validate_layer_runtime(compatible_runtime: str) -> str | None:
-    if compatible_runtime is not None and compatible_runtime not in RUNTIMES:
-        return f"Value '{compatible_runtime}' at 'compatibleRuntime' failed to satisfy constraint: Member must satisfy enum value set: [ruby2.6, dotnetcore1.0, python3.7, nodejs8.10, nasa, ruby2.7, python2.7-greengrass, dotnetcore2.0, python3.8, java21, dotnet6, dotnetcore2.1, python3.9, java11, nodejs6.10, provided, dotnetcore3.1, dotnet8, java17, nodejs, nodejs4.3, java8.al2, go1.x, nodejs20.x, go1.9, byol, nodejs10.x, provided.al2023, python3.10, java8, nodejs12.x, python3.11, nodejs8.x, python3.12, nodejs14.x, nodejs8.9, nodejs16.x, provided.al2, nodejs4.3-edge, nodejs18.x, ruby3.2, python3.4, ruby2.5, python3.6, python2.7]"
+    if compatible_runtime is not None and compatible_runtime not in ALL_RUNTIMES:
+        return f"Value '{compatible_runtime}' at 'compatibleRuntime' failed to satisfy constraint: Member must satisfy enum value set: {VALID_LAYER_RUNTIMES}"
     return None
 
 
@@ -628,8 +601,8 @@ def validate_layer_runtimes_and_architectures(
 ):
     validations = []
 
-    if compatible_runtimes and set(compatible_runtimes).difference(RUNTIMES):
-        constraint = "Member must satisfy enum value set: [java17, provided, nodejs16.x, nodejs14.x, ruby2.7, python3.10, java11, python3.11, dotnet6, go1.x, nodejs18.x, provided.al2, java8, java8.al2, ruby3.2, python3.7, python3.8, python3.9]"
+    if compatible_runtimes and set(compatible_runtimes).difference(ALL_RUNTIMES):
+        constraint = f"Member must satisfy enum value set: {VALID_RUNTIMES}"
         validation_msg = f"Value '[{', '.join([s for s in compatible_runtimes])}]' at 'compatibleRuntimes' failed to satisfy constraint: {constraint}"
         validations.append(validation_msg)
 

diff --git a/localstack/services/lambda_/invocation/docker_runtime_executor.py b/localstack/services/lambda_/invocation/docker_runtime_executor.py
@@ -13,7 +13,7 @@
     INVOCATION_PORT,
     ExecutorEndpoint,
 )
-from localstack.services.lambda_.invocation.lambda_models import IMAGE_MAPPING, FunctionVersion
+from localstack.services.lambda_.invocation.lambda_models import FunctionVersion
 from localstack.services.lambda_.invocation.runtime_executor import (
     LambdaRuntimeException,
     RuntimeExecutor,
@@ -24,6 +24,7 @@
     get_main_endpoint_from_container,
 )
 from localstack.services.lambda_.packages import lambda_runtime_package
+from localstack.services.lambda_.runtimes import IMAGE_MAPPING
 from localstack.utils.container_networking import get_main_container_name
 from localstack.utils.container_utils.container_client import (
     ContainerConfiguration,

diff --git a/localstack/services/lambda_/invocation/lambda_models.py b/localstack/services/lambda_/invocation/lambda_models.py
@@ -42,31 +42,6 @@
 
 LOG = logging.getLogger(__name__)
 
-# To add support for a new runtime, just add it here with the accompanying image postfix and to api_utils.RUNTIMES
-IMAGE_MAPPING = {
-    "python3.7": "python:3.7",
-    "python3.8": "python:3.8",
-    "python3.9": "python:3.9",
-    "python3.10": "python:3.10",
-    "python3.11": "python:3.11",
-    "nodejs12.x": "nodejs:12",
-    "nodejs14.x": "nodejs:14",
-    "nodejs16.x": "nodejs:16",
-    "nodejs18.x": "nodejs:18",
-    "ruby2.7": "ruby:2.7",
-    "ruby3.2": "ruby:3.2",
-    "java8": "java:8",
-    "java8.al2": "java:8.al2",
-    "java11": "java:11",
-    "java17": "java:17",
-    "dotnetcore3.1": "dotnet:core3.1",
-    "dotnet6": "dotnet:6",
-    "go1.x": "go:1",
-    "provided": "provided:alami",
-    "provided.al2": "provided:al2",
-}
-SNAP_START_SUPPORTED_RUNTIMES = [Runtime.java11, Runtime.java17]
-
 
 # TODO: maybe we should make this more "transient" by always initializing to Pending and *not* persisting it?
 @dataclasses.dataclass(frozen=True)

diff --git a/localstack/services/lambda_/provider.py b/localstack/services/lambda_/provider.py
@@ -137,7 +137,10 @@
 from localstack.services.edge import ROUTER
 from localstack.services.lambda_ import api_utils
 from localstack.services.lambda_ import hooks as lambda_hooks
-from localstack.services.lambda_.api_utils import ARCHITECTURES, STATEMENT_ID_REGEX
+from localstack.services.lambda_.api_utils import (
+    ARCHITECTURES,
+    STATEMENT_ID_REGEX,
+)
 from localstack.services.lambda_.event_source_listeners.event_source_listener import (
     EventSourceListener,
 )
@@ -147,8 +150,6 @@
     EnvironmentStartupTimeoutException,
 )
 from localstack.services.lambda_.invocation.lambda_models import (
-    IMAGE_MAPPING,
-    SNAP_START_SUPPORTED_RUNTIMES,
     AliasRoutingConfig,
     CodeSigningConfig,
     EventInvokeConfig,
@@ -184,6 +185,12 @@
 from localstack.services.lambda_.invocation.models import LambdaStore
 from localstack.services.lambda_.invocation.runtime_executor import get_runtime_executor
 from localstack.services.lambda_.layerfetcher.layer_fetcher import LayerFetcher
+from localstack.services.lambda_.runtimes import (
+    ALL_RUNTIMES,
+    DEPRECATED_RUNTIMES,
+    SNAP_START_SUPPORTED_RUNTIMES,
+    VALID_RUNTIMES,
+)
 from localstack.services.lambda_.urlrouter import FunctionUrlRouter
 from localstack.services.plugins import ServiceLifecycleHook
 from localstack.state import StateVisitor
@@ -709,6 +716,12 @@ def create_function(
         context: RequestContext,
         request: CreateFunctionRequest,
     ) -> FunctionConfiguration:
+        zip_file = request.get("Code", {}).get("ZipFile")
+        if zip_file and len(zip_file) > config.LAMBDA_LIMITS_CODE_SIZE_ZIPPED:
+            raise RequestEntityTooLargeException(
+                f"Zipped size must be smaller than {config.LAMBDA_LIMITS_CODE_SIZE_ZIPPED} bytes"
+            )
+
         if context.request.content_length > config.LAMBDA_LIMITS_CREATE_FUNCTION_REQUEST_SIZE:
             raise RequestEntityTooLargeException(
                 f"Request must be smaller than {config.LAMBDA_LIMITS_CREATE_FUNCTION_REQUEST_SIZE} bytes for the CreateFunction operation"
@@ -745,16 +758,22 @@ def create_function(
             )
         package_type = request.get("PackageType", PackageType.Zip)
         runtime = request.get("Runtime")
-        if package_type == PackageType.Zip and runtime not in IMAGE_MAPPING:
+        if package_type == PackageType.Zip and runtime not in ALL_RUNTIMES:
             raise InvalidParameterValueException(
-                f"Value {request.get('Runtime')} at 'runtime' failed to satisfy constraint: Member must satisfy enum value set: [java17, provided, nodejs16.x, nodejs14.x, ruby2.7, python3.10, java11, python3.11, dotnet6, go1.x, nodejs18.x, provided.al2, java8, java8.al2, ruby3.2, python3.7, python3.8, python3.9] or be a valid ARN",
+                f"Value {request.get('Runtime')} at 'runtime' failed to satisfy constraint: Member must satisfy enum value set: {VALID_RUNTIMES} or be a valid ARN",
                 Type="User",
             )
+        function_name = request["FunctionName"]
+        if runtime in DEPRECATED_RUNTIMES:
+            LOG.warning(
+                f"The Lambda runtime {runtime} is deprecated. "
+                f"Please upgrade the runtime for the function {function_name}: "
+                f"https://docs.aws.amazon.com/lambda/latest/dg/lambda-runtimes.html"
+            )
         if snap_start := request.get("SnapStart"):
             self._validate_snapstart(snap_start, runtime)
         state = lambda_stores[context.account_id][context.region]
 
-        function_name = request["FunctionName"]
         with self.create_fn_lock:
             if function_name in state.functions:
                 raise ResourceConflictException(f"Function already exist: {function_name}")
@@ -942,11 +961,18 @@ def update_function_configuration(
             )
 
         if "Runtime" in request:
-            if request["Runtime"] not in IMAGE_MAPPING:
+            runtime = request["Runtime"]
+            if runtime not in ALL_RUNTIMES:
                 raise InvalidParameterValueException(
-                    f"Value {request.get('Runtime')} at 'runtime' failed to satisfy constraint: Member must satisfy enum value set: [java17, provided, nodejs16.x, nodejs14.x, ruby2.7, python3.10, java11, python3.11, dotnet6, go1.x, nodejs18.x, provided.al2, java8, java8.al2, ruby3.2, python3.7, python3.8, python3.9] or be a valid ARN",
+                    f"Value {runtime} at 'runtime' failed to satisfy constraint: Member must satisfy enum value set: {VALID_RUNTIMES} or be a valid ARN",
                     Type="User",
                 )
+            if runtime in DEPRECATED_RUNTIMES:
+                LOG.warning(
+                    f"The Lambda runtime {runtime} is deprecated. "
+                    f"Please upgrade the runtime for the function {function_name}: "
+                    f"https://docs.aws.amazon.com/lambda/latest/dg/lambda-runtimes.html"
+                )
             replace_kwargs["runtime"] = request["Runtime"]
 
         if snap_start := request.get("SnapStart"):
@@ -1795,6 +1821,13 @@ def list_event_source_mappings(
     # ============ FUNCTION URLS ============
     # =======================================
 
+    @staticmethod
+    def _validate_qualifier(qualifier: str) -> None:
+        if qualifier == "$LATEST" or (qualifier and api_utils.qualifier_is_version(qualifier)):
+            raise ValidationException(
+                f"1 validation error detected: Value '{qualifier}' at 'qualifier' failed to satisfy constraint: Member must satisfy regular expression pattern: ((?!^\\d+$)^[0-9a-zA-Z-_]+$)"
+            )
+
     # TODO: what happens if function state is not active?
     def create_function_url_config(
         self,
@@ -1810,14 +1843,8 @@ def create_function_url_config(
         function_name, qualifier = api_utils.get_name_and_qualifier(
             function_name, qualifier, context
         )
-        if qualifier == "$LATEST":
-            raise ValidationException(
-                "1 validation error detected: Value '$LATEST' at 'qualifier' failed to satisfy constraint: Member must satisfy regular expression pattern: ((?!^\\d+$)^[0-9a-zA-Z-_]+$)"
-            )
-        if qualifier and api_utils.qualifier_is_version(qualifier):
-            raise ValidationException(
-                f"1 validation error detected: Value '{qualifier}' at 'qualifier' failed to satisfy constraint: Member must satisfy regular expression pattern: (^\\$LATEST$)|((?!^[0-9]+$)([a-zA-Z0-9-_]+))"
-            )
+        self._validate_qualifier(qualifier)
+
         fn = state.functions.get(function_name)
         if fn is None:
             raise ResourceNotFoundException("Function does not exist", Type="User")
@@ -1881,14 +1908,7 @@ def get_function_url_config(
 
         fn_name, qualifier = api_utils.get_name_and_qualifier(function_name, qualifier, context)
 
-        if qualifier == "$LATEST":
-            raise ValidationException(
-                "1 validation error detected: Value '$LATEST' at 'qualifier' failed to satisfy constraint: Member must satisfy regular expression pattern: ((?!^\\d+$)^[0-9a-zA-Z-_]+$)"
-            )
-        if qualifier and api_utils.qualifier_is_version(qualifier):
-            raise ValidationException(
-                f"1 validation error detected: Value '{qualifier}' at 'qualifier' failed to satisfy constraint: Member must satisfy regular expression pattern: (^\\$LATEST$)|((?!^[0-9]+$)([a-zA-Z0-9-_]+))"
-            )
+        self._validate_qualifier(qualifier)
 
         resolved_fn = state.functions.get(fn_name)
         if not resolved_fn:
@@ -1919,14 +1939,7 @@ def update_function_url_config(
         function_name, qualifier = api_utils.get_name_and_qualifier(
             function_name, qualifier, context
         )
-        if qualifier == "$LATEST":
-            raise ValidationException(
-                "1 validation error detected: Value '$LATEST' at 'qualifier' failed to satisfy constraint: Member must satisfy regular expression pattern: ((?!^\\d+$)^[0-9a-zA-Z-_]+$)"
-            )
-        if qualifier and api_utils.qualifier_is_version(qualifier):
-            raise ValidationException(
-                f"1 validation error detected: Value '{qualifier}' at 'qualifier' failed to satisfy constraint: Member must satisfy regular expression pattern: (^\\$LATEST$)|((?!^[0-9]+$)([a-zA-Z0-9-_]+))"
-            )
+        self._validate_qualifier(qualifier)
 
         fn = state.functions.get(function_name)
         if not fn:
@@ -1975,14 +1988,8 @@ def delete_function_url_config(
         function_name, qualifier = api_utils.get_name_and_qualifier(
             function_name, qualifier, context
         )
-        if qualifier == "$LATEST":
-            raise ValidationException(
-                "1 validation error detected: Value '$LATEST' at 'qualifier' failed to satisfy constraint: Member must satisfy regular expression pattern: ((?!^\\d+$)^[0-9a-zA-Z-_]+$)"
-            )
-        if qualifier and api_utils.qualifier_is_version(qualifier):
-            raise ValidationException(
-                f"1 validation error detected: Value '{qualifier}' at 'qualifier' failed to satisfy constraint: Member must satisfy regular expression pattern: (^\\$LATEST$)|((?!^[0-9]+$)([a-zA-Z0-9-_]+))"
-            )
+        self._validate_qualifier(qualifier)
+
         resolved_fn = state.functions.get(function_name)
         if not resolved_fn:
             raise ResourceNotFoundException(
@@ -3542,7 +3549,7 @@ def _get_tags(self, function: Function) -> dict[str, str]:
     def _store_tags(self, function: Function, tags: dict[str, str]):
         if len(tags) > LAMBDA_TAG_LIMIT_PER_RESOURCE:
             raise InvalidParameterValueException(
-                "Number of tags exceeds function tag limit.", Type="User"
+                "Number of tags exceeds resource tag limit.", Type="User"
             )
         with function.lock:
             function.tags = tags
@@ -3564,18 +3571,19 @@ def tag_resource(self, context: RequestContext, resource: FunctionArn, tags: Tag
                 "An error occurred and the request cannot be processed.", Type="User"
             )
 
+        # TODO: test layer (added in snapshot update 2023-11)
         pattern_match = api_utils.FULL_FN_ARN_PATTERN.search(resource)
         if not pattern_match:
             raise ValidationException(
-                rf"1 validation error detected: Value '{resource}' at 'resource' failed to satisfy constraint: Member must satisfy regular expression pattern: arn:(aws[a-zA-Z-]*)?:lambda:[a-z]{{2}}((-gov)|(-iso(b?)))?-[a-z]+-\d{{1}}:\d{{12}}:function:[a-zA-Z0-9-_]+(:(\$LATEST|[a-zA-Z0-9-_]+))?"
+                rf"1 validation error detected: Value '{resource}' at 'resource' failed to satisfy constraint: Member must satisfy regular expression pattern: arn:(aws[a-zA-Z-]*)?:lambda:[a-z]{{2}}((-gov)|(-iso(b?)))?-[a-z]+-\d{{1}}:\d{{12}}:(function:[a-zA-Z0-9-_]+(:(\$LATEST|[a-zA-Z0-9-_]+))?|layer:[a-zA-Z0-9-_]+)"
             )
 
         groups = pattern_match.groupdict()
         fn_name = groups.get("function_name")
 
         if groups.get("qualifier"):
             raise InvalidParameterValueException(
-                "Tagging operations are permitted on Lambda functions only. Tags on aliases and versions are not supported. Please specify either a function name or a function ARN.",
+                "Tags on function aliases and versions are not supported. Please specify a function ARN.",
                 Type="User",
             )