Add NodeJS 20 support for Lambda by ataylorme · Pull Request #9659 · localstack/localstack · GitHub
Skip to content
This repository was archived by the owner on Mar 23, 2026. It is now read-only.

Add NodeJS 20 support for Lambda#9659

Closed
ataylorme wants to merge 2 commits into
localstack:masterfrom
ataylorme:lambda-node20
Closed

Add NodeJS 20 support for Lambda#9659
ataylorme wants to merge 2 commits into
localstack:masterfrom
ataylorme:lambda-node20

Conversation

@ataylorme

@ataylorme ataylorme commented Nov 16, 2023

Copy link
Copy Markdown
Contributor

Motivation

I am upgrading my Lambdas to NodeJS 20, which is now supported by AWS, as it is the current LTS version and want to test them with localstack

Changes

Adds NodeJS 20 support for Lambda

Testing

I was unable to test locally. I will spend more time on my local environment but any help testing and updating snapshots is appreciated

TODO

  • update test snapshots
  • update documentation

@localstack-bot

localstack-bot commented Nov 16, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

localstack-bot
localstack-bot reviewed Nov 16, 2023
View reviewed changes

@localstack-bot localstack-bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to LocalStack! Thanks for raising your first Pull Request and landing in your contributions. Our team will reach out with any reviews or feedbacks that we have shortly. We recommend joining our Slack Community and share your PR on the #community channel to share your contributions with us. Please make sure you are following our contributing guidelines and our Code of Conduct.

@ataylorme

ataylorme commented Nov 16, 2023

Copy link
Copy Markdown
Contributor Author

I have read the CLA Document and I hereby sign the CLA

localstack-bot added a commit that referenced this pull request Nov 16, 2023
@localstack-bot
@ataylorme has signed the CLA from Pull Request #9659
7209913
DavidTanner
DavidTanner reviewed Nov 21, 2023
View reviewed changes
Comment thread localstack/aws/api/lambda_/__init__.py Outdated
@mh1622 mh1622 mentioned this pull request Nov 22, 2023
Closed
1 task
@joe4dev

joe4dev commented Nov 22, 2023

Copy link
Copy Markdown
Member

Thank you @ataylorme for the initiative 👏👏👏 and @DavidTanner for the proactive review comment 👍

Some comments:

  • The API stubs in the __init__.py are automatically generated by our framework AWS Server Framework (ASF) and should not be edited manually. We have a nice blog post that summarizes ASF and snapshot-based parity testing: https://blog.localstack.cloud/2022-08-04-parity-explained/
  • As you pointed out correctly, the snapshot and documentation need to be updated. Updating the snapshots is key for parity.
  • We have experienced inconsistencies around runtime updates in the past (even ourselves) leading to bugfixes (e.g., related to layers validating compatible runtimes) after adding a new runtime.
  • We also have another community PR for adding the new Java 21 runtime Support Java21 in Lambda #9685. Adding all new runtimes in one go makes it easier to update the snapshots at once.

Therefore, we decided to improve the organization of runtimes to allow easier and faster updates in the future. We have prepared this PR #9697

I hope this is ok for you @ataylorme. I can add you as a co-author once I merge the PR for proper credits 🥇 .

We are looking forward to supporting new runtimes much easier and faster in the future 🚀

This was referenced Nov 22, 2023
Closed
Merged
@ataylorme

ataylorme commented Nov 23, 2023

Copy link
Copy Markdown
Contributor Author

@joe4dev thank you for the detailed response. The more organized, single PR absolutely makes sense. I’m looking forward to it shipping in an upcoming release. Cheers!

@ataylorme ataylorme closed this Nov 23, 2023
@joe4dev

joe4dev commented Nov 23, 2023

Copy link
Copy Markdown
Member

@ataylorme ataylorme deleted the lambda-node20 branch November 28, 2023 22:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@joe4dev joe4dev Awaiting requested review from joe4dev
@dominikschubert dominikschubert Awaiting requested review from dominikschubert
@dfangl dfangl Awaiting requested review from dfangl
2 more reviewers
@DavidTanner DavidTanner DavidTanner left review comments
@localstack-bot localstack-bot localstack-bot left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ataylorme @localstack-bot @joe4dev @DavidTanner