Simplify localstack init user config by joe4dev · Pull Request #9446 · localstack/localstack · GitHub
Skip to content
This repository was archived by the owner on Mar 23, 2026. It is now read-only.

Simplify localstack init user config#9446

Merged
joe4dev merged 2 commits into
masterfrom
simplify-localstack-init-user-config
Oct 23, 2023
Merged

Simplify localstack init user config#9446
joe4dev merged 2 commits into
masterfrom
simplify-localstack-init-user-config

Conversation

@joe4dev

@joe4dev joe4dev commented Oct 23, 2023

Copy link
Copy Markdown
Member

Depends on localstack/lambda-runtime-init#26

Motivation

This PR simplifies the user's configuration in the Lambda init Go binary. We drop root privileges in the Lambda init Go binary by default and offer a configuration variable to skip this parity feature. However, it is cumbersome to configure using a misleading empty string "". We skip dropping privileges when LAMBDA_INIT_USER is set to root ("" is still supported but discouraged).
This is much easier to configure and leads to less errors around escaping quotes etc.

Changes

  • Bump Lambda init version skipping privileges drop with root
  • Fix the LocalStack configuration logic for ""

@joe4dev joe4dev added the semver: patch Non-breaking changes which can be included in patch releases label Oct 23, 2023
@joe4dev joe4dev self-assigned this Oct 23, 2023

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ls devs: Just be careful when using LAMBDA_INIT_USER in combination with init debugging.

We could also consider flipping this 🤷

@coveralls

Copy link
Copy Markdown

Coverage Status

coverage: 82.93% (-0.02%) from 82.949% when pulling be06ba6 on simplify-localstack-init-user-config into 6bbfbce on master.

@github-actions

Copy link
Copy Markdown

@joe4dev joe4dev merged commit 829fcf1 into master Oct 23, 2023
@joe4dev joe4dev deleted the simplify-localstack-init-user-config branch October 23, 2023 16:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

semver: patch Non-breaking changes which can be included in patch releases

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants