{{ message }}
This repository was archived by the owner on Mar 23, 2026. It is now read-only.
Add removal warning for legacy lambda provider#9203
Merged
Conversation
Initial attempt for a utility to collect deprecations for specific values of environment variables.
This reverts commit a26c773.
joe4dev
commented
Sep 21, 2023
Member
Author
There was a problem hiding this comment.
Do we want/need this prominently at startup?
Member
Author
There was a problem hiding this comment.
Yes. The Lambda team discussed this makes sense for Lambda given the substantial difference. We want to highlight this and push users to adopt v2 or raise any blocking issues.
Member
Author
There was a problem hiding this comment.
Notice that the language differs from the lazily loaded message. This message is aligned to the regular LS-startup deprecation warnings.
joe4dev
added
the
semver: minor
dfangl
approved these changes
Sep 25, 2023
dfangl
left a comment
dfangl
left a comment
Member
There was a problem hiding this comment.
LGTM! But why do we have the warning twice?
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
v2provider became available as opt-in.v1provider was deprecated and we encouraged users to opt-in to our new Lambdav2provider.v2became the default implementation Switch to new Lambda provider implementation #6724.v1provider (this PR). We also ship the Lambda invocation loop rework Lambda invocation loop rework #8970 (re-write of data plane).Changes
Add a log warning when the legacy Lambda v1 provider is used. Only logged during initialization (
on_after_init) for people using the legacy Lambda service.Discussion
Pro-active warnings at LocalStack startup:
PROVIDER_OVERRIDE_LAMBDA=v1at the startup of LocalStack? We currently do not support this withEnvVarDeprecation. I drafted anEnvVarValueDeprecationina26c77375but reverted it because it needs further updates in the logging message and telemetry if we even need this.Consistency: Trying to align the language for the deprecations and removals of s3, lambda, stepfunctions /cc