Make AWS region name configurable for tests by joe4dev · Pull Request #9070 · localstack/localstack · GitHub
Skip to content
This repository was archived by the owner on Mar 23, 2026. It is now read-only.

Make AWS region name configurable for tests#9070

Merged
joe4dev merged 2 commits into
masterfrom
make-aws-region-name-configurable-for-tests
Sep 6, 2023
Merged

Make AWS region name configurable for tests#9070
joe4dev merged 2 commits into
masterfrom
make-aws-region-name-configurable-for-tests

Conversation

@joe4dev

@joe4dev joe4dev commented Sep 5, 2023

Copy link
Copy Markdown
Member

Motivation

We should have a configuration to change the test region. For cross-account tests, we should be able to configure the region in order to test cross-account tests within the same region.

Discovered during testing of the Lambda invocation loop rework #8970
/cc @dfangl @dominikschubert

Changes

Makes the AWS region name configurable in tests.

@joe4dev joe4dev added the semver: patch Non-breaking changes which can be included in patch releases label Sep 5, 2023
@joe4dev joe4dev self-assigned this Sep 5, 2023
@joe4dev

joe4dev commented Sep 5, 2023

Copy link
Copy Markdown
Member Author

@github-actions

github-actions Bot commented Sep 5, 2023

Copy link
Copy Markdown

LocalStack Community integration with Pro

       2 files         2 suites   1h 31m 5s ⏱️
2 166 tests 1 679 ✔️ 487 💤 0
2 167 runs  1 679 ✔️ 488 💤 0

Results for commit 952a547.

♻️ This comment has been updated with latest results.

@viren-nadkarni viren-nadkarni left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Removing the suffix `_NAME` aligns the environment variable naming with the AWS CLI using `AWS_REGION` (which overwrites `AWS_DEFAULT_REGION`).
https://docs.aws.amazon.com/cli/latest/userguide/cli-configure-envvars.html
@joe4dev

joe4dev commented Sep 6, 2023

Copy link
Copy Markdown
Member Author

We could also consider dropping the _NAME suffix to match the AWS_REGION config 🤔

Align environment variable naming with AWS CLI using TEST_AWS_REGION without the _NAME suffix.

Removing the suffix _NAME aligns the environment variable naming with the AWS CLI using AWS_REGION (which overwrites AWS_DEFAULT_REGION).
https://docs.aws.amazon.com/cli/latest/userguide/cli-configure-envvars.html

@joe4dev

joe4dev commented Sep 6, 2023

Copy link
Copy Markdown
Member Author

@joe4dev joe4dev merged commit 7afdbab into master Sep 6, 2023
@joe4dev joe4dev deleted the make-aws-region-name-configurable-for-tests branch September 6, 2023 14:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

semver: patch Non-breaking changes which can be included in patch releases

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants