{{ message }}
This repository was archived by the owner on Mar 23, 2026. It is now read-only.
Update PULL_REQUEST_TEMPLATE.md#8831
Merged
Merged
Conversation
alexrashed
approved these changes
Aug 7, 2023
alexrashed
left a comment
Member
There was a problem hiding this comment.
Nice! The structure is simple and has already proven useful. 🚀
viren-nadkarni
approved these changes
Aug 7, 2023
viren-nadkarni
left a comment
Member
There was a problem hiding this comment.
Suggesting a 'Related' section. LGTM otherwise!
|
|
||
| - [ ] ... | ||
| - [ ] ... | ||
|
|
Member
Author
There was a problem hiding this comment.
i would argue that these should go into the motivation section
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Motivation
It's been on the TODO list for a long time to create a PR template. The initial attempt in #6084 ended up becoming stale, mostly because the template was a little too involved. Moreover, the long list of check boxes in the template lead to all issues having something like "2 of 14 tasks" indicators in the overview, which is a bit misleading, since some of them are single choice lists so PRs will always appear as incomplete unless you delete the list of tasks.
The Motivation and Changes structure has found itself into many PRs by a number of Authors. Examples:
So it seems this could be a good minimal standard structure!
Changes